mirror of
https://github.com/supabase/supabase.git
synced 2026-10-09 19:35:06 +03:00
Gildas GarciaandIvan Vasilov
96d43099bb
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
23 lines
762 B
TypeScript
23 lines
762 B
TypeScript
'use client'
|
|
|
|
import { Button } from 'ui'
|
|
|
|
export default function CopyButtonVerbs() {
|
|
return (
|
|
<div className="flex flex-row gap-16">
|
|
<div className="flex flex-col gap-4">
|
|
<span className="text-xs text-foreground-muted">Bad Example</span>
|
|
<Button variant="primary">Table creation</Button>
|
|
<Button variant="primary">Save action</Button>
|
|
<Button variant="danger">Bucket deletion</Button>
|
|
</div>
|
|
<div className="flex flex-col gap-4">
|
|
<span className="text-xs text-foreground-muted">Good Example</span>
|
|
<Button variant="primary">Create table</Button>
|
|
<Button variant="primary">Save changes</Button>
|
|
<Button variant="danger">Delete bucket</Button>
|
|
</div>
|
|
</div>
|
|
)
|
|
}
|