mirror of
https://github.com/supabase/supabase.git
synced 2026-10-06 18:05:11 +03:00
## Problem Primary colour serves readable text and selected controls, but those uses need different shades. Light mode needs darker text, while dark mode needs a deeper button fill. Fixed brand green on interactive chrome also prevents a custom primary hue from carrying through the interface. Some slider tracks and selected text are hard to read. ## Solution - Keep `--primary` for accessible text and small selected indicators. Use `--primary-solid` for button fills, which need a deeper shade in dark mode. - Add `--primary-bright` for focus rings, selected control chrome, chart accents, and other interactive highlights. It follows `--primary-hue`; `brand-*` stays fixed for Supabase identity. - Make slider troughs clearer and text selection translucent with theme foreground text. - Document the split in the design-system colour guide. | Before | After | | --- | --- | | <img width="980" height="244" alt="Before: light mode primary controls" src="https://github.com/user-attachments/assets/dfae325d-0dfe-4231-8bcd-3f89c4b9d793" /> | <img width="982" height="204" alt="After: light mode primary controls" src="https://github.com/user-attachments/assets/5fdcb531-a6e3-4549-8a13-9d9a5ebe6e20" /> | | <img width="610" height="120" alt="Before: slider track" src="https://github.com/user-attachments/assets/04f768e0-51e8-4d06-9b97-c52f4a34f122" /> | <img width="622" height="126" alt="After: slider track" src="https://github.com/user-attachments/assets/95127f4e-13dc-4f0f-b63c-cf5d70a28b42" /> | | <img width="652" height="512" alt="Before: dark mode controls" src="https://github.com/user-attachments/assets/3f88de66-90cc-40ee-8cf1-b5f4eb87b09a" /> | <img width="658" height="498" alt="After: dark mode controls" src="https://github.com/user-attachments/assets/906bec30-6ca1-4614-9fb3-6cf5e5feec22" /> | ## Review instructions 1. Compare light and dark mode in the [colour usage guide](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/color-usage#primary-and-brand-colors). Check primary ink, primary-solid, primary-bright, and fixed brand swatches. 2. In Studio, open the ‘new table’ sheet in [Table Editor](https://studio-staging-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/dashboard/project/_/editor). Tab through the new table sheet's fields and toggles. Check the focus rings, selected controls, and the sheet's edges in both themes. You do not need to save a table. 3. Select text in Studio in both themes, including a link or primary-coloured label. The selection and text should remain legible. 4. Check the [Field](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/field) Price Range slider: the unused track should remain visible in both themes. The selected field card border should follow primary-bright. 5. Check the [Button](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/button) and [Radio Group](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/components/radio-group) previews. In dark mode, `primary` button fill should be deeper than primary [text](https://design-system-git-dnywh-fix-bright-brand-chrome-supabase.vercel.app/design-system/docs/color-usage#text); selected radios should remain readable.
143 lines
3.9 KiB
TypeScript
143 lines
3.9 KiB
TypeScript
'use client'
|
|
|
|
import { BarChart2, ExternalLink } from 'lucide-react'
|
|
import { useEffect, useState } from 'react'
|
|
import {
|
|
Chart,
|
|
ChartActions,
|
|
ChartBar,
|
|
ChartCard,
|
|
ChartContent,
|
|
ChartEmptyState,
|
|
ChartHeader,
|
|
ChartLine,
|
|
ChartLoadingState,
|
|
ChartTitle,
|
|
} from 'ui-patterns/Chart'
|
|
|
|
export default function ComposedChartBasic() {
|
|
const [isLoading, setIsLoading] = useState(true)
|
|
|
|
const actions = [
|
|
{
|
|
label: 'Open in Logs Explorer',
|
|
onClick: () => {
|
|
alert('Ta da! You clicked me! 🎉')
|
|
},
|
|
icon: <ExternalLink size={12} />,
|
|
},
|
|
]
|
|
|
|
const data = Array.from({ length: 40 }, (_, i) => {
|
|
const date = new Date()
|
|
date.setMinutes(date.getMinutes() - i * 3) // Each point 3 minutes apart
|
|
|
|
const progress = i / 40
|
|
const standard_score = Math.floor(55 + progress * 55 + (Math.random() - 0.5) * 12)
|
|
const performance = Math.floor(35 + progress * 35 + (Math.random() - 0.5) * 10)
|
|
const efficiency = Math.floor(25 + progress * 25 + (Math.random() - 0.5) * 12)
|
|
|
|
return {
|
|
timestamp: date.toISOString(),
|
|
standard_score: Math.max(0, Math.min(100, standard_score)),
|
|
performance: Math.max(0, Math.min(100, performance)),
|
|
efficiency: Math.max(0, Math.min(100, efficiency)),
|
|
}
|
|
}).reverse()
|
|
|
|
const chartConfig = {
|
|
standard_score: {
|
|
label: 'Standard Score',
|
|
color: 'var(--primary-bright)',
|
|
},
|
|
performance: {
|
|
label: 'Performance',
|
|
color: 'var(--chart-2)',
|
|
},
|
|
efficiency: {
|
|
label: 'Efficiency',
|
|
color: 'var(--chart-5)',
|
|
},
|
|
}
|
|
|
|
useEffect(() => {
|
|
setTimeout(() => {
|
|
setIsLoading(false)
|
|
}, 1000)
|
|
}, [])
|
|
|
|
return (
|
|
<div className="flex flex-col gap-6 w-8/12">
|
|
<Chart isLoading={isLoading}>
|
|
<ChartCard>
|
|
<ChartHeader>
|
|
<ChartTitle tooltip="This is a tooltip">Standard Bar Chart</ChartTitle>
|
|
<ChartActions actions={actions} />
|
|
</ChartHeader>
|
|
<ChartContent
|
|
isEmpty={data.length === 0}
|
|
emptyState={
|
|
<ChartEmptyState
|
|
icon={<BarChart2 size={16} />}
|
|
title="No data to show"
|
|
description="It may take up to 24 hours for data to refresh"
|
|
/>
|
|
}
|
|
loadingState={<ChartLoadingState />}
|
|
>
|
|
<div className="h-40">
|
|
<ChartBar
|
|
data={data}
|
|
dataKey="standard_score"
|
|
showGrid={false}
|
|
showYAxis={true}
|
|
YAxisProps={{
|
|
tickFormatter: (value) => `${value}k`,
|
|
width: 36,
|
|
}}
|
|
isFullHeight={true}
|
|
/>
|
|
</div>
|
|
</ChartContent>
|
|
</ChartCard>
|
|
</Chart>
|
|
|
|
<Chart isLoading={isLoading}>
|
|
<ChartCard>
|
|
<ChartHeader>
|
|
<ChartTitle tooltip="This is a tooltip">Standard Line Chart</ChartTitle>
|
|
<ChartActions actions={actions} />
|
|
</ChartHeader>
|
|
<ChartContent
|
|
isEmpty={data.length === 0}
|
|
emptyState={
|
|
<ChartEmptyState
|
|
icon={<BarChart2 size={16} />}
|
|
title="No data to show"
|
|
description="It may take up to 24 hours for data to refresh"
|
|
/>
|
|
}
|
|
loadingState={<ChartLoadingState />}
|
|
>
|
|
<div className="h-40">
|
|
<ChartLine
|
|
data={data}
|
|
dataKey="standard_score"
|
|
dataKeys={['standard_score', 'performance', 'efficiency']}
|
|
config={chartConfig}
|
|
showGrid={true}
|
|
showYAxis={true}
|
|
YAxisProps={{
|
|
tickFormatter: (value) => `${value}k`,
|
|
width: 36,
|
|
}}
|
|
isFullHeight={true}
|
|
/>
|
|
</div>
|
|
</ChartContent>
|
|
</ChartCard>
|
|
</Chart>
|
|
</div>
|
|
)
|
|
}
|