Danny White
476d4a5851
refactor(ui): drop redundant Button variant="default" props ( #50161 )
...
## What kind of change does this PR introduce?
Mechanical cleanup on top of the Button default-variant change (#50160 ).
## What is the current behavior?
Many callsites still pass `variant="default"` even though that is now
the component default.
## What is the new behavior?
Removes redundant static `variant="default"` from legacy `Button` and
`ButtonTooltip` callsites. Keeps explicit defaults where they document
the API:
- `button-default.tsx` and `button-sizes.tsx` demos
- `DocsButton`, which pins neutral styling at the wrapper boundary
## To test
Studio:
- [Auth → Rate
Limits](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/auth/rate-limits ):
dirty the form so Cancel appears; Cancel stays neutral, Save stays green
- [Project Settings → API
Keys](https://studio-staging-2s957kwc4-supabase.vercel.app/dashboard/project/_/settings/api-keys ):
`DocsButton` in the header actions stays neutral
Design system:
- [Design system →
Button](https://design-system-git-dnywh-dc924ac1-supabase.vercel.app/design-system/docs/components/button ):
`button-default` / `button-sizes` still show explicit default styling;
Primary (green) is restricted to the Primary section (and `asChild`)
WWW:
- [www → Brand
assets](https://zone-www-dot-com-git-dnywh-dc924ac1-supabase.vercel.app/brand-assets ):
Download logo kit / Download button kit stay neutral
2026-09-11 17:05:26 +10:00
Gildas Garcia and Ivan Vasilov
96d43099bb
chore: refactor Button API so that it can be used a standard button ( #46880 )
...
## Problem
Our `<Button>` component breaks the default `button` contract by
redefining the `type` prop to set its variant (`primary`, `default`,
etc) instead of the button type (`submit`, `button`, etc).
This is confusing and forces to write more code when using it with
shadcn components that expect/inject the standard button props.
## Solution
- rename the `type` prop to `variant`
- rename the `htmlType` prop to `type`
- propagate the changes where necessary
- format code
## How to test
As this is just prop renaming, if it builds it's ok
---------
Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com >
2026-06-16 23:59:58 +02:00
Joshen Lim
7f5865872a
Enforce noUnusedLocals and noUnusedParameters in tsconfig.json + fix all related issues ( #45264 )
...
## Context
Enforce `noUnusedLocals` and `noUnusedParameters` in tsconfig.json + fix
all related issues
2026-04-27 17:42:34 +08:00
4a0bb36ca8
style: require sorted imports in studio/components ( #44408 )
...
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com >
2026-04-01 10:22:37 +02:00
Danny White and Joshen Lim
d653617cdd
chore(studio): improve inline code styling ( #40724 )
...
* sweep language
* update class docs
* additional
* basic docs
* sweep relevant instances
* replace text-code
* additional in sweep
* Tiny fix
* prettier
---------
Co-authored-by: Joshen Lim <joshenlimek@gmail.com >
2025-11-24 16:34:30 +08:00
Ivan Vasilov
43cc61818c
chore: Migrate all isPending uses in react-query ( #40642 )
...
* Bump react-query. Minor type and logic fixes.
* Migrate all use of isLoading to isPending in mutations.
* Fix type errors.
2025-11-20 16:44:53 +01:00
Joshen Lim
bcf943ee88
Advisor rules update for LW15 ( #37202 )
...
* Advisor rules update for LW15
* Simplify UX to confirmation modal
* Rename section to settings
* fix
* patchy
* further simplify
* Smol styling fix
* Create + Delete lint rules to also invalidate lints
2025-07-16 22:20:08 +08:00
Danny White