From eb8b69615aad8b20724694c2f6784db2d40b95a8 Mon Sep 17 00:00:00 2001
From: Jordi Enric <37541088+jordienr@users.noreply.github.com>
Date: Tue, 22 Oct 2024 10:39:14 +0200
Subject: [PATCH 1/2] fix log detail (#29979)

fix log detail loading
---
 .../interfaces/Settings/Logs/LogSelection.tsx |  5 ++--
 .../WorkflowRunSelectionRenderer.tsx          | 30 +++++++++----------
 .../interfaces/Settings/Logs/Logs.types.ts    |  1 +
 3 files changed, 17 insertions(+), 19 deletions(-)

diff --git a/apps/studio/components/interfaces/Settings/Logs/LogSelection.tsx b/apps/studio/components/interfaces/Settings/Logs/LogSelection.tsx
index bb453cc0cf1..eba4b2545f5 100644
--- a/apps/studio/components/interfaces/Settings/Logs/LogSelection.tsx
+++ b/apps/studio/components/interfaces/Settings/Logs/LogSelection.tsx
@@ -119,9 +119,8 @@ const LogSelection = ({
         return <AuthSelectionRenderer log={fullLog} />
 
       case 'workflow_run':
-        if (!fullLog) return null
-        if (!fullLog.metadata) return <DefaultPreviewSelectionRenderer log={fullLog} />
-        return <WorkflowRunSelectionRenderer log={fullLog} />
+        if (!partialLog) return null
+        return <WorkflowRunSelectionRenderer log={partialLog} />
 
       default:
         if (queryType && fullLog && isDefaultLogPreviewFormat(fullLog)) {
diff --git a/apps/studio/components/interfaces/Settings/Logs/LogSelectionRenderers/WorkflowRunSelectionRenderer.tsx b/apps/studio/components/interfaces/Settings/Logs/LogSelectionRenderers/WorkflowRunSelectionRenderer.tsx
index c81dcdd6631..c90ad0af21c 100644
--- a/apps/studio/components/interfaces/Settings/Logs/LogSelectionRenderers/WorkflowRunSelectionRenderer.tsx
+++ b/apps/studio/components/interfaces/Settings/Logs/LogSelectionRenderers/WorkflowRunSelectionRenderer.tsx
@@ -1,5 +1,4 @@
 import { LOGS_TAILWIND_CLASSES } from '../Logs.constants'
-import type { PreviewLogData } from '../Logs.types'
 import {
   IDFormatter,
   jsonSyntaxHighlight,
@@ -7,35 +6,34 @@ import {
   SelectionDetailedTimestampRow,
 } from '../LogsFormatters'
 
-const WorkflowRunSelectionRenderer = ({ log }: { log: PreviewLogData }) => {
+const WorkflowRunSelectionRenderer = ({
+  log,
+}: {
+  log: {
+    event_message: string
+    timestamp: number
+    id: string
+    workflow_run?: string
+  }
+}) => {
   console.log('log:', log)
   return (
     <div className={`${LOGS_TAILWIND_CLASSES.log_selection_x_padding} space-y-6`}>
       <div className="flex flex-col gap-3">
         <h3 className="text-foreground-lighter text-sm">Event Message</h3>
         <div className="text-xs text-wrap font-mono text-foreground whitespace-pre-wrap overflow-x-auto">
-          {log.metadata?.msg || log.event_message}
+          {log.event_message}
         </div>
       </div>
 
       <SelectionDetailedTimestampRow value={log.timestamp} />
-      {log.metadata?.workflow_run && (
+      {log.workflow_run && (
         <SelectionDetailedRow
           label="Workflow Run ID"
-          value={String(log.metadata?.workflow_run)}
-          valueRender={<IDFormatter value={log.metadata?.workflow_run} />}
+          value={String(log.workflow_run)}
+          valueRender={<IDFormatter value={log.workflow_run} />}
         />
       )}
-
-      <div className="flex flex-col gap-3">
-        <h3 className="text-foreground-lighter text-sm">Metadata</h3>
-        <pre
-          className=" className={`text-foreground col-span-8 overflow-x-auto text-xs font-mono`}"
-          dangerouslySetInnerHTML={{
-            __html: jsonSyntaxHighlight(log.metadata!),
-          }}
-        />
-      </div>
     </div>
   )
 }
diff --git a/apps/studio/components/interfaces/Settings/Logs/Logs.types.ts b/apps/studio/components/interfaces/Settings/Logs/Logs.types.ts
index 3111271b411..60b691f303e 100644
--- a/apps/studio/components/interfaces/Settings/Logs/Logs.types.ts
+++ b/apps/studio/components/interfaces/Settings/Logs/Logs.types.ts
@@ -35,6 +35,7 @@ export interface PreviewLogData extends CustomLogData {
   timestamp: number
   event_message: string
   metadata?: Metadata
+  workflow_run?: string
 }
 export type LogData = CustomLogData & PreviewLogData
 

From 8b02941136e147b956de8576b83bb3c31d10f90c Mon Sep 17 00:00:00 2001
From: Alaister Young <a@alaisteryoung.com>
Date: Tue, 22 Oct 2024 16:41:42 +0800
Subject: [PATCH 2/2] remove check from view logs on prod branch

---
 .../BranchManagement/BranchPanels.tsx         | 25 +++----------------
 .../WorkflowRunSelectionRenderer.tsx          |  1 -
 2 files changed, 3 insertions(+), 23 deletions(-)

diff --git a/apps/studio/components/interfaces/BranchManagement/BranchPanels.tsx b/apps/studio/components/interfaces/BranchManagement/BranchPanels.tsx
index ee1134a260d..f090e34b6fc 100644
--- a/apps/studio/components/interfaces/BranchManagement/BranchPanels.tsx
+++ b/apps/studio/components/interfaces/BranchManagement/BranchPanels.tsx
@@ -235,30 +235,11 @@ export const BranchRow = ({
                   </Link>
                 </Button>
                 {branchingWorkflowLogsEnabled && (
-                  <ButtonTooltip
-                    type="default"
-                    asChild
-                    disabled={branch.status === 'CREATING_PROJECT'}
-                    tooltip={{
-                      content: {
-                        side: 'bottom',
-                        text:
-                          branch.status === 'CREATING_PROJECT'
-                            ? 'Branch is still creating. Logs will be available once the branch is active'
-                            : undefined,
-                      },
-                    }}
-                  >
-                    <Link
-                      href={
-                        branch.status === 'CREATING_PROJECT'
-                          ? '#'
-                          : `/project/${branch.project_ref}/logs/workflow-run-logs`
-                      }
-                    >
+                  <Button type="default" asChild>
+                    <Link href={`/project/${branch.project_ref}/logs/workflow-run-logs`}>
                       View Logs
                     </Link>
-                  </ButtonTooltip>
+                  </Button>
                 )}
                 <DropdownMenu modal={false}>
                   <DropdownMenuTrigger asChild>
diff --git a/apps/studio/components/interfaces/Settings/Logs/LogSelectionRenderers/WorkflowRunSelectionRenderer.tsx b/apps/studio/components/interfaces/Settings/Logs/LogSelectionRenderers/WorkflowRunSelectionRenderer.tsx
index c90ad0af21c..054522560c2 100644
--- a/apps/studio/components/interfaces/Settings/Logs/LogSelectionRenderers/WorkflowRunSelectionRenderer.tsx
+++ b/apps/studio/components/interfaces/Settings/Logs/LogSelectionRenderers/WorkflowRunSelectionRenderer.tsx
@@ -16,7 +16,6 @@ const WorkflowRunSelectionRenderer = ({
     workflow_run?: string
   }
 }) => {
-  console.log('log:', log)
   return (
     <div className={`${LOGS_TAILWIND_CLASSES.log_selection_x_padding} space-y-6`}>
       <div className="flex flex-col gap-3">