From d8b485f020798ec2f32f2ac13ddad00d1ec682ac Mon Sep 17 00:00:00 2001 From: Hieu Date: Mon, 5 Oct 2026 16:26:15 +0700 Subject: [PATCH] Apply batched suggestions from code review Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- .../components/interfaces/Settings/Logs/LogTable.tsx | 2 +- apps/studio/hooks/misc/useCheckPermissionsV2.ts | 2 +- .../pages/project/[ref]/auth/templates/[templateId].tsx | 7 ++++--- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/apps/studio/components/interfaces/Settings/Logs/LogTable.tsx b/apps/studio/components/interfaces/Settings/Logs/LogTable.tsx index f61cfbf4f18..037a1445b0f 100644 --- a/apps/studio/components/interfaces/Settings/Logs/LogTable.tsx +++ b/apps/studio/components/interfaces/Settings/Logs/LogTable.tsx @@ -177,7 +177,7 @@ export const LogTable = ({ const { can: canCreateLogQuery } = useAsyncCheckUserContentPermissions( FGA_PERMISSIONS.PROJECT.SNIPPETS_WRITE, - { mode: 'create', type: 'report' } + { mode: 'create', type: 'log_sql' } ) const firstRow = data[0] diff --git a/apps/studio/hooks/misc/useCheckPermissionsV2.ts b/apps/studio/hooks/misc/useCheckPermissionsV2.ts index 8bb7152ef91..73a75d6dd5b 100644 --- a/apps/studio/hooks/misc/useCheckPermissionsV2.ts +++ b/apps/studio/hooks/misc/useCheckPermissionsV2.ts @@ -90,7 +90,7 @@ function useGetProjectPermissionsV2( enabled: getProjectDataFromParamsRef, }) const project = - projectRefOverride === undefined || projectData?.parent_project_ref + projectRefOverride === undefined ? projectData : { ref: projectRefOverride, parent_project_ref: undefined } diff --git a/apps/studio/pages/project/[ref]/auth/templates/[templateId].tsx b/apps/studio/pages/project/[ref]/auth/templates/[templateId].tsx index ab5daa8be34..ea1549cbfcd 100644 --- a/apps/studio/pages/project/[ref]/auth/templates/[templateId].tsx +++ b/apps/studio/pages/project/[ref]/auth/templates/[templateId].tsx @@ -77,9 +77,10 @@ const RedirectToTemplates = () => { FGA_PERMISSIONS.PROJECT.AUTH_CONFIG_READ ) - const { can: canUpdateConfig } = useAsyncCheckPermissionsV2( - FGA_PERMISSIONS.PROJECT.AUTH_CONFIG_WRITE - ) + const { can: canUpdateConfig } = useAsyncCheckPermissionsV2([ + FGA_PERMISSIONS.PROJECT.AUTH_CONFIG_WRITE, + FGA_PERMISSIONS.PROJECT.ADMIN_WRITE, + ]) const { data: authConfig, isPending: isLoadingConfig } = useAuthConfigQuery({ projectRef }) const { data: selectedOrganization } = useSelectedOrganizationQuery()