From c888bb754f4a61cd10423e400605839d4e7db69d Mon Sep 17 00:00:00 2001 From: Nikhil Nayak Date: Tue, 7 Dec 2021 13:46:50 +0530 Subject: [PATCH] Bugfix [#4088]: Make table search case-insensitive --- .gitignore | 1 + .../TableEditorLayout/TableEditorMenu.tsx | 130 ++++++++++-------- 2 files changed, 73 insertions(+), 58 deletions(-) diff --git a/.gitignore b/.gitignore index 4d7e8457010..e5840f62fad 100644 --- a/.gitignore +++ b/.gitignore @@ -99,6 +99,7 @@ typings/ .dynamodb/ .vscode +.idea .vercel #include template .env file for docker-compose diff --git a/studio/components/layouts/TableEditorLayout/TableEditorMenu.tsx b/studio/components/layouts/TableEditorLayout/TableEditorMenu.tsx index c9d257d912d..3dbbda35fd9 100644 --- a/studio/components/layouts/TableEditorLayout/TableEditorMenu.tsx +++ b/studio/components/layouts/TableEditorLayout/TableEditorMenu.tsx @@ -36,13 +36,13 @@ interface Props { } const TableEditorMenu: FC = ({ - selectedSchema, - onSelectSchema = () => {}, - onAddTable = () => {}, - onEditTable = () => {}, - onDeleteTable = () => {}, - onDuplicateTable = () => {}, -}) => { + selectedSchema, + onSelectSchema = () => {}, + onAddTable = () => {}, + onEditTable = () => {}, + onDeleteTable = () => {}, + onDuplicateTable = () => {}, + }) => { const { meta, ui } = useStore() const router = useRouter() const { id } = router.query @@ -74,11 +74,15 @@ const TableEditorMenu: FC = ({ setIsRefreshing(false) } - const schemas = meta.schemas.list() - const tables = meta.tables.list((table: PostgresTable) => table.schema === selectedSchema) + const schemas: any[] = meta.schemas.list() + const tables: any[] = meta.tables.list((table: PostgresTable) => table.schema === selectedSchema) const schemaTables = - searchText.length === 0 ? tables : tables.filter((table) => table.name.includes(searchText)) + searchText.length === 0 + ? tables + : tables.filter((table) => + table.name.toLowerCase().includes(searchText.toLowerCase()) + ) const filteredSchemaViews = searchText.length === 0 @@ -90,18 +94,19 @@ const TableEditorMenu: FC = ({ const maxScrollHeight = schemaViews.length > 0 ? 270 : 520 return ( -
+
{/* Schema selection dropdown */} -
+
{meta.schemas.isLoading ? ( -
- +
+ Loading schemas...
) : ( } - size="tiny" + size='tiny' value={selectedSchema} onChange={(name: string) => { setSearchText('') @@ -110,7 +115,8 @@ const TableEditorMenu: FC = ({ }} > {schemas.map((schema) => ( - + {schema.name} ))} @@ -118,13 +124,13 @@ const TableEditorMenu: FC = ({ )}
-
+
{/* Add new table button */} {selectedSchema === 'public' && (