From c6b502cd379da273232b60dbfe25800071170eef Mon Sep 17 00:00:00 2001 From: Joshen Lim Date: Fri, 22 Nov 2024 17:10:54 +0800 Subject: [PATCH] Address all comments --- .../interfaces/SQLEditor/AiAssistantPanel/index.tsx | 3 --- apps/studio/components/ui/AIAssistantPanel/AIAssistant.tsx | 4 ---- .../components/ui/AIAssistantPanel/AiAssistant.constants.ts | 1 - apps/studio/lib/constants/telemetry.ts | 4 ++-- 4 files changed, 2 insertions(+), 10 deletions(-) diff --git a/apps/studio/components/interfaces/SQLEditor/AiAssistantPanel/index.tsx b/apps/studio/components/interfaces/SQLEditor/AiAssistantPanel/index.tsx index c66c6f3b77f..d27eebd1d8f 100644 --- a/apps/studio/components/interfaces/SQLEditor/AiAssistantPanel/index.tsx +++ b/apps/studio/components/interfaces/SQLEditor/AiAssistantPanel/index.tsx @@ -103,9 +103,6 @@ export const AiAssistantPanel = ({ existingSql, entityDefinitions: entityDefinitions, }, - onError: (error) => { - console.log('Boom: ', error) - }, }) const messages = useMemo(() => { const merged = [...chatMessages.map((m) => ({ ...m, isDebug: false }))] diff --git a/apps/studio/components/ui/AIAssistantPanel/AIAssistant.tsx b/apps/studio/components/ui/AIAssistantPanel/AIAssistant.tsx index e67ef4d8b9e..0d032e777c9 100644 --- a/apps/studio/components/ui/AIAssistantPanel/AIAssistant.tsx +++ b/apps/studio/components/ui/AIAssistantPanel/AIAssistant.tsx @@ -127,10 +127,6 @@ export const AIAssistant = ({ projectRef: project?.ref, connectionString: project?.connectionString, }, - - onError: (error) => { - console.log('error:', JSON.stringify(error)) - }, }) const canUpdateOrganization = useCheckPermissions(PermissionAction.UPDATE, 'organizations') diff --git a/apps/studio/components/ui/AIAssistantPanel/AiAssistant.constants.ts b/apps/studio/components/ui/AIAssistantPanel/AiAssistant.constants.ts index f5a9488aec4..e9bc5bdeb55 100644 --- a/apps/studio/components/ui/AIAssistantPanel/AiAssistant.constants.ts +++ b/apps/studio/components/ui/AIAssistantPanel/AiAssistant.constants.ts @@ -1,4 +1,3 @@ -import { databaseKeys } from 'data/database/keys' import { SupportedAssistantEntities } from './AIAssistant.types' export const ASSISTANT_SUPPORT_ENTITIES: { diff --git a/apps/studio/lib/constants/telemetry.ts b/apps/studio/lib/constants/telemetry.ts index 5d5a6f70b33..7dd06282380 100644 --- a/apps/studio/lib/constants/telemetry.ts +++ b/apps/studio/lib/constants/telemetry.ts @@ -13,7 +13,7 @@ export enum TELEMETRY_VALUES { /** * Track whenever a prompt is submitted to the AI (excluding debug prompts) * @context AI Assistant V2 - * @purpose Indication of engagement with the feature, aid in prioritising efforts into the assistant itself + * @purpose Indication of engagement with the feature, aid in prioritizing efforts into the assistant itself */ PROMPT_SUBMITTED = 'prompt-submitted', /** @@ -25,7 +25,7 @@ export enum TELEMETRY_VALUES { /** * Track running a SQL suggestion from AI Assistant * @context AI Assistant V2 - * @purpose Indication of usefulness of AI assistant response, aid in prioritising tweak of Assistant prompts to adjust output quality + * @purpose Indication of usefulness of AI assistant response, aid in prioritizing tweak of Assistant prompts to adjust output quality * @details Broken down into "select" or "mutation", and for the latter further broken down to the type of query (e.g "functions" or "rls-policies", default to unknown otherwise) * */ RAN_SQL_SUGGESTION = 'ran-sql-suggestion',