From b764e57b659307421a21aea055be5d0e1d5bd97b Mon Sep 17 00:00:00 2001 From: Ali Waseem Date: Thu, 19 Feb 2026 08:46:35 -0700 Subject: [PATCH] fix: remove autocomplete on filter bar and update filter actions (#43020) ## I have read the [CONTRIBUTING.md](https://github.com/supabase/supabase/blob/master/CONTRIBUTING.md) file. YES ## What kind of change does this PR introduce? - remove auto complete from filter bar + password manager - Update color of operator --- packages/ui-patterns/src/FilterBar/FilterCondition.tsx | 10 +++++++++- packages/ui-patterns/src/FilterBar/FilterGroup.tsx | 8 ++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/packages/ui-patterns/src/FilterBar/FilterCondition.tsx b/packages/ui-patterns/src/FilterBar/FilterCondition.tsx index 8f7b2425a3f..4a7d4c7cdeb 100644 --- a/packages/ui-patterns/src/FilterBar/FilterCondition.tsx +++ b/packages/ui-patterns/src/FilterBar/FilterCondition.tsx @@ -242,11 +242,15 @@ export function FilterCondition({ onFocus={() => handleOperatorFocus(path)} onBlur={handleOperatorBlur} onKeyDown={handleOperatorKeyDown} - className="h-full border-none bg-transparent py-0 px-1 text-center text-xs focus:outline-none focus:ring-0 focus:shadow-none focus-visible:ring-0 focus-visible:ring-offset-0 text-brand w-full absolute left-0 top-0" + className="h-full border-none bg-transparent py-0 px-1 text-center text-xs focus:outline-none focus:ring-0 focus:shadow-none focus-visible:ring-0 focus-visible:ring-offset-0 text-foreground w-full absolute left-0 top-0" disabled={isLoading} aria-label={`Operator for ${property.label}`} data-testid={`filter-operator-${property.name}`} tabIndex={-1} + autoComplete="off" + data-1p-ignore + data-lpignore="true" + data-form-type="other" /> {condition.operator || ' '} @@ -291,6 +295,10 @@ export function FilterCondition({ aria-label={`Value for ${property.label}`} data-testid={`filter-value-${property.name}`} tabIndex={-1} + autoComplete="off" + data-1p-ignore + data-lpignore="true" + data-form-type="other" /> {localValue || ' '} diff --git a/packages/ui-patterns/src/FilterBar/FilterGroup.tsx b/packages/ui-patterns/src/FilterBar/FilterGroup.tsx index c256effe0c1..3341a4b44f6 100644 --- a/packages/ui-patterns/src/FilterBar/FilterGroup.tsx +++ b/packages/ui-patterns/src/FilterBar/FilterGroup.tsx @@ -196,6 +196,10 @@ export function FilterGroup({ group, path }: FilterGroupProps) { } disabled={isLoading} data-testid="filter-bar-freeform-input" + autoComplete="off" + data-1p-ignore + data-lpignore="true" + data-form-type="other" /> ) : (
@@ -210,6 +214,10 @@ export function FilterGroup({ group, path }: FilterGroupProps) { className="h-full border-none bg-transparent py-0 text-xs focus:outline-none focus:ring-0 focus:shadow-none focus-visible:ring-0 focus-visible:ring-offset-0 w-full absolute left-0 top-0 px-2" placeholder="+ Add filter" disabled={isLoading} + autoComplete="off" + data-1p-ignore + data-lpignore="true" + data-form-type="other" /> {(isActive ? freeformText : localFreeformValue) || '+'}