mirror of
https://github.com/supabase/supabase.git
synced 2026-10-10 20:05:06 +03:00
chore: refactor Button API so that it can be used a standard button (#46880)
## Problem Our `<Button>` component breaks the default `button` contract by redefining the `type` prop to set its variant (`primary`, `default`, etc) instead of the button type (`submit`, `button`, etc). This is confusing and forces to write more code when using it with shadcn components that expect/inject the standard button props. ## Solution - rename the `type` prop to `variant` - rename the `htmlType` prop to `type` - propagate the changes where necessary - format code ## How to test As this is just prop renaming, if it builds it's ok --------- Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>
This commit is contained in:
1 parent
608040b8cb
commit
96d43099bb
1105 files changed
+2713
-2545
No files matched your search
@@ -99,7 +99,7 @@ export const SimpleCodeBlock = ({
|
||||
</pre>
|
||||
{showCopy && (
|
||||
<div className="invisible absolute right-0 top-0 opacity-0 transition-opacity group-hover:visible group-hover:opacity-100">
|
||||
<Button size="tiny" type="default" onClick={() => handleCopyCode(children)}>
|
||||
<Button size="tiny" variant="default" onClick={() => handleCopyCode(children)}>
|
||||
{showCopied ? 'Copied' : 'Copy'}
|
||||
</Button>
|
||||
</div>
|
||||
|
||||
Reference in new issue
Block a user