From 930a09fbbf71fbda09c9770349abb1e5ba63bc15 Mon Sep 17 00:00:00 2001 From: Joshen Lim Date: Wed, 10 Aug 2022 15:33:57 +0800 Subject: [PATCH] Resolve comments --- .../Organization/TeamSettings/TeamSettings.utils.ts | 4 ++-- .../components/interfaces/TableGridEditor/TableGridEditor.tsx | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/studio/components/interfaces/Organization/TeamSettings/TeamSettings.utils.ts b/studio/components/interfaces/Organization/TeamSettings/TeamSettings.utils.ts index fb6dc9c7005..c301a667fcd 100644 --- a/studio/components/interfaces/Organization/TeamSettings/TeamSettings.utils.ts +++ b/studio/components/interfaces/Organization/TeamSettings/TeamSettings.utils.ts @@ -15,12 +15,12 @@ export const getRolesManagementPermissions = ( const selectedRole = roles.find((r) => r.name === role) if (!selectedRole) return - const canAdd = checkPermissions(PermissionAction.CREATE, 'postgres.auth.subject_roles', { + const canAdd = checkPermissions(PermissionAction.CREATE, 'auth.subject_roles', { resource: { role_id: selectedRole!.id }, }) if (canAdd) rolesAddable.push(selectedRole.id) - const canRemove = checkPermissions(PermissionAction.DELETE, 'postgres.auth.subject_roles', { + const canRemove = checkPermissions(PermissionAction.DELETE, 'auth.subject_roles', { resource: { role_id: selectedRole!.id }, }) if (canRemove) rolesRemovable.push(selectedRole.id) diff --git a/studio/components/interfaces/TableGridEditor/TableGridEditor.tsx b/studio/components/interfaces/TableGridEditor/TableGridEditor.tsx index 743aaf714bf..cf30488cb21 100644 --- a/studio/components/interfaces/TableGridEditor/TableGridEditor.tsx +++ b/studio/components/interfaces/TableGridEditor/TableGridEditor.tsx @@ -64,6 +64,7 @@ const TableGridEditor: FC = ({ } const tableId = selectedTable?.id + // const canUpdate = checkPermissions(PermissionAction.TENANT_SQL_UPDATE, String(tableId)) // const canAdminWrite = checkPermissions(PermissionAction.TENANT_SQL_ADMIN_WRITE, String(tableId)) // const canInsert = checkPermissions(PermissionAction.CREATE, String(tableId)) // const canUpdate = checkPermissions(PermissionAction.UPDATE, String(tableId))