From 8ecf8fa11c3d94db91d9030cde73a99425c8f688 Mon Sep 17 00:00:00 2001
From: Jonathan Summers-Muir <MildTomato@users.noreply.github.com>
Date: Fri, 1 Nov 2024 19:08:00 +0800
Subject: [PATCH] fix errors

---
 .../DiskManagement/DiskManagement.utils.ts    | 25 ++++++++++---------
 .../DiskManagement/fields/IOPSField.tsx       |  3 ++-
 2 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/apps/studio/components/interfaces/DiskManagement/DiskManagement.utils.ts b/apps/studio/components/interfaces/DiskManagement/DiskManagement.utils.ts
index 65c1cf5b5db..dc743688d7a 100644
--- a/apps/studio/components/interfaces/DiskManagement/DiskManagement.utils.ts
+++ b/apps/studio/components/interfaces/DiskManagement/DiskManagement.utils.ts
@@ -257,11 +257,7 @@ export const calculateMaxIopsAllowedForComputeSize = (computeSize: string): numb
 
 export const calculateComputeSizeRequiredForIops = (
   iops: number
-): ComputeInstanceAddonVariantId => {
-  if (iops === undefined || iops === null) {
-    throw new Error('IOPS is required')
-  }
-
+): ComputeInstanceAddonVariantId | undefined => {
   const computeSizes = Object.entries(COMPUTE_BASELINE_IOPS).sort((a, b) => a[1] - b[1])
   for (const [size, baselineIops] of computeSizes) {
     if (iops <= baselineIops) {
@@ -273,13 +269,20 @@ export const calculateComputeSizeRequiredForIops = (
   return computeSizes[computeSizes.length - 1][0] as ComputeInstanceAddonVariantId
 }
 
-export const calculateDiskSizeRequiredForIops = (provisionedIOPS: number): number => {
+export const calculateDiskSizeRequiredForIops = (provisionedIOPS: number): number | undefined => {
+  if (!provisionedIOPS) {
+    console.error('IOPS is required')
+    return undefined
+  }
+
   if (isNaN(provisionedIOPS) || provisionedIOPS < 0) {
-    throw new Error('Provisioned IOPS must be a non-negative number')
+    console.error('IOPS must be a non-negative number')
+    return undefined
   }
 
   if (provisionedIOPS > 256000) {
-    throw new Error('Maximum allowed IOPS is 256000')
+    console.error('Maximum allowed IOPS is 256000')
+    return undefined
   }
 
   return Math.max(1, Math.ceil(provisionedIOPS / 1000))
@@ -292,8 +295,6 @@ export const formatComputeName = (compute: string) => {
 export const mapComputeSizeNameToAddonVariantId = (
   computeSize: ProjectDetail['infra_compute_size']
 ): ComputeInstanceAddonVariantId => {
-  if (!computeSize) throw new Error('Compute size is required')
-
   return {
     nano: 'ci_nano',
     micro: 'ci_micro',
@@ -306,11 +307,11 @@ export const mapComputeSizeNameToAddonVariantId = (
     '8xlarge': 'ci_8xlarge',
     '12xlarge': 'ci_12xlarge',
     '16xlarge': 'ci_16xlarge',
-  }[computeSize] as ComputeInstanceAddonVariantId
+  }[computeSize ?? 'nano'] as ComputeInstanceAddonVariantId
 }
 
 export const mapAddOnVariantIdToComputeSize = (
-  addonVariantId: ComputeInstanceAddonVariantId
+  addonVariantId: ComputeInstanceAddonVariantId = 'ci_nano'
 ): ComputeInstanceSize => {
   return {
     ci_nano: 'Nano',
diff --git a/apps/studio/components/interfaces/DiskManagement/fields/IOPSField.tsx b/apps/studio/components/interfaces/DiskManagement/fields/IOPSField.tsx
index d884a7ebba3..69d369dd9a1 100644
--- a/apps/studio/components/interfaces/DiskManagement/fields/IOPSField.tsx
+++ b/apps/studio/components/interfaces/DiskManagement/fields/IOPSField.tsx
@@ -15,6 +15,7 @@ import { BillingChangeBadge } from '../ui/BillingChangeBadge'
 import { ComputeSizeRecommendationSection } from '../ui/ComputeSizeRecommendationSection'
 import {
   COMPUTE_BASELINE_IOPS,
+  DISK_LIMITS,
   DiskType,
   RESTRICTED_COMPUTE_FOR_IOPS_ON_GP3,
 } from '../ui/DiskManagement.constants'
@@ -67,7 +68,7 @@ export function IOPSField({ form, disableInput }: IOPSFieldProps) {
                     <Button
                       type="default"
                       onClick={() => {
-                        setValue('computeSize', reccomendedComputeSize)
+                        setValue('computeSize', reccomendedComputeSize ?? 'ci_nano')
                         trigger('provisionedIOPS')
                       }}
                     >