From 8a0565a3862824aaadecf9ca73a4fe4fe2e50ff3 Mon Sep 17 00:00:00 2001 From: phamhieu Date: Thu, 20 Apr 2023 07:44:55 +0700 Subject: [PATCH] fix: page_view should use dynamic route instead of the browser url --- studio/components/ui/PageTelemetry.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/studio/components/ui/PageTelemetry.tsx b/studio/components/ui/PageTelemetry.tsx index 200eff94301..fab8328c67f 100644 --- a/studio/components/ui/PageTelemetry.tsx +++ b/studio/components/ui/PageTelemetry.tsx @@ -10,8 +10,8 @@ const PageTelemetry: FC = ({ children }) => { const { ui } = useStore() useEffect(() => { - function handleRouteChange(url: string) { - handlePageTelemetry(url) + function handleRouteChange() { + handlePageTelemetry(router.route) } // Listen for page changes after a navigation or when the query changes @@ -19,7 +19,7 @@ const PageTelemetry: FC = ({ children }) => { return () => { router.events.off('routeChangeComplete', handleRouteChange) } - }, [router.events]) + }, [router]) useEffect(() => { /** @@ -27,7 +27,7 @@ const PageTelemetry: FC = ({ children }) => { * if the route is not ready. Don't need to send it will be picked up by router.event above */ if (router.isReady) { - handlePageTelemetry(router.asPath) + handlePageTelemetry(router.route) } }, [])