From 81bb997d5a8bf85aaaa05536b954b04e7bffd57f Mon Sep 17 00:00:00 2001
From: Jordi Enric <jordi.err@gmail.com>
Date: Fri, 22 Nov 2024 13:44:00 +0100
Subject: [PATCH] update events to fllow naming convention

---
 .../Integrations/CronJobs/CreateCronJobSheet.tsx          | 6 ++++--
 .../interfaces/Integrations/CronJobs/CronJobCard.tsx      | 8 ++++----
 apps/studio/data/telemetry/send-event-mutation.ts         | 1 +
 .../studio/pages/project/[ref]/integrations/cron-jobs.tsx | 4 ++--
 4 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/apps/studio/components/interfaces/Integrations/CronJobs/CreateCronJobSheet.tsx b/apps/studio/components/interfaces/Integrations/CronJobs/CreateCronJobSheet.tsx
index 8407a8134f8..179cad12b25 100644
--- a/apps/studio/components/interfaces/Integrations/CronJobs/CreateCronJobSheet.tsx
+++ b/apps/studio/components/interfaces/Integrations/CronJobs/CreateCronJobSheet.tsx
@@ -195,8 +195,10 @@ export const CreateCronJobSheet = ({
     // We should allow sending custom properties with events
     sendEvent({
       category: 'cron_jobs',
-      action: isEditing ? 'update_cron_job' : 'create_cron_job',
-      label: isEditing ? '_' : '_',
+      action: isEditing ? 'update_cron_job_clicked' : 'create_cron_job_clicked',
+      label: isEditing
+        ? 'user clicked update cron job button'
+        : 'user clicked create cron job button',
       properties: {
         cron_job_type: values.type,
         cron_job_schedule: schedule,
diff --git a/apps/studio/components/interfaces/Integrations/CronJobs/CronJobCard.tsx b/apps/studio/components/interfaces/Integrations/CronJobs/CronJobCard.tsx
index 01ecec1b986..54df896f022 100644
--- a/apps/studio/components/interfaces/Integrations/CronJobs/CronJobCard.tsx
+++ b/apps/studio/components/interfaces/Integrations/CronJobs/CronJobCard.tsx
@@ -88,8 +88,8 @@ export const CronJobCard = ({ job, onEditCronJob, onDeleteCronJob }: CronJobCard
                       onClick={() => {
                         sendEvent({
                           category: 'cron_jobs',
-                          action: 'view_previous_runs',
-                          label: 'cron_job_viewed',
+                          action: 'view_previous_runs_clicked',
+                          label: 'user clicked view previous runs button',
                         })
                       }}
                     >
@@ -101,8 +101,8 @@ export const CronJobCard = ({ job, onEditCronJob, onDeleteCronJob }: CronJobCard
                     onClick={() => {
                       sendEvent({
                         category: 'cron_jobs',
-                        action: 'delete_cron_job',
-                        label: 'cron_job_deleted',
+                        action: 'delete_cron_job_clicked',
+                        label: 'user clicked delete cron job button',
                       })
                       onDeleteCronJob(job)
                     }}
diff --git a/apps/studio/data/telemetry/send-event-mutation.ts b/apps/studio/data/telemetry/send-event-mutation.ts
index 3462905c476..4d0580cdafd 100644
--- a/apps/studio/data/telemetry/send-event-mutation.ts
+++ b/apps/studio/data/telemetry/send-event-mutation.ts
@@ -14,6 +14,7 @@ export type SendEventVariables = {
   category: string
   label: string
   value?: string
+  properties?: Record<string, any>
 }
 
 type SendEventPayload = any
diff --git a/apps/studio/pages/project/[ref]/integrations/cron-jobs.tsx b/apps/studio/pages/project/[ref]/integrations/cron-jobs.tsx
index cb97437c337..3ff9ffdfdf0 100644
--- a/apps/studio/pages/project/[ref]/integrations/cron-jobs.tsx
+++ b/apps/studio/pages/project/[ref]/integrations/cron-jobs.tsx
@@ -61,8 +61,8 @@ const CronJobsPage: NextPageWithLayout = () => {
                     onClick={() => {
                       sendEvent({
                         category: 'cron_jobs',
-                        action: 'open_create_cron_job_sheet',
-                        label: 'open_create_cron_job_sheet',
+                        action: 'create_cron_job_clicked',
+                        label: 'user clicked create cron job button',
                       })
                       setCreateCronJobSheetShown({
                         jobname: '',