From 7fbe48af55fb8425e09bf8ddfd070fc4193ed690 Mon Sep 17 00:00:00 2001
From: Ivan Vasilov <vasilov.ivan@gmail.com>
Date: Fri, 6 Oct 2023 10:15:37 +0200
Subject: [PATCH] fix: Fix the loading state on the Continue with Github button
 (#17959)

Use the loading state on the continue with github button on sign-in.
---
 studio/components/interfaces/SignIn/SignInWithGitHub.tsx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/studio/components/interfaces/SignIn/SignInWithGitHub.tsx b/studio/components/interfaces/SignIn/SignInWithGitHub.tsx
index 4a5eb812cc1..04199436011 100644
--- a/studio/components/interfaces/SignIn/SignInWithGitHub.tsx
+++ b/studio/components/interfaces/SignIn/SignInWithGitHub.tsx
@@ -35,7 +35,6 @@ const SignInWithGitHub = () => {
       if (error) throw error
     } catch (error) {
       console.error(error)
-    } finally {
       setLoading(false)
     }
   }
@@ -44,7 +43,8 @@ const SignInWithGitHub = () => {
     <Button
       block
       onClick={handleGithubSignIn}
-      icon={<IconGitHub width={18} height={18} />}
+      // set the width to 20 so that it matches the loading spinner and don't push the text when loading
+      icon={<IconGitHub width={20} height={18} />}
       size="large"
       type="default"
       loading={loading}