dima/supabase
1
0 Fork 0
mirror of https://github.com/supabase/supabase.git synced 2026-10-05 09:25:06 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Make self hosted tests more reliable locally and in CI (#40479)

Browse Source 
* added ui studio command

* added SKIP ASSET UPLOAD option

* updated failing tests

* updated e2e scripts to include CI instructions

* removed unused envs and slack messages

* updated timeouts and max retries on CI

* updated generated local env

* updated env

* updated env generation for e2e tests

* remove vercel preview

* updated tests and trying junit report on PR

* update test comment

* updated commit hash for reporter

* updated file path

* updated runner to blacksmith

* update test file for reporting

* Update .github/workflows/studio-e2e-test.yml

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>

* Update package.json

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>

* Update e2e/studio/playwright.config.ts

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>

* updated to skip comment on forks

---------

Co-authored-by: Charis <26616127+charislam@users.noreply.github.com>
This commit is contained in:
Ali WaseemandCharis authored and GitHub committed 2025-11-17 15:00:31 -07:00
1 parent 482c225f29
commit 7898abe06c
8 files changed
+72 -157
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

e2e/studio/features/_global.setup.ts
-12
View File
@@ -25,18 +25,6 @@ setup('Global Setup', async ({ page }) => {
- Is Platform: ${IS_PLATFORM}
`)
/*
* Check if we're in CI, if so, check VERCEL_AUTOMATION_BYPASS_SELFHOSTED_STUDIO
* is set to true.
*/
const VERCEL_BYPASS = process.env.VERCEL_AUTOMATION_BYPASS_SELFHOSTED_STUDIO
if (process.env.CI === 'true') {
if (!VERCEL_BYPASS || VERCEL_BYPASS.length === 0) {
throw new Error('VERCEL_AUTOMATION_BYPASS_SELFHOSTED_STUDIO is not set')
}
}
/**
* Studio Check
*/
e2e/studio/features/database.spec.ts
+25 -6
View File
@@ -185,7 +185,11 @@ test.describe.serial('Database', () => {
// drop database tables if exists
if ((await page.getByText(databaseTableNameNew, { exact: true }).count()) > 0) {
await page.getByRole('row', { name: databaseTableNameNew }).getByRole('button').click()
await page
.getByRole('row', { name: databaseTableNameNew })
.getByRole('button')
.last()
.click()
await page.getByRole('menuitem', { name: 'Delete table' }).click()
await page.getByRole('checkbox', { name: 'Drop table with cascade?' }).check()
await page.getByRole('button', { name: 'Delete' }).click()
@@ -193,7 +197,11 @@ test.describe.serial('Database', () => {
}
if ((await page.getByText(databaseTableNameUpdated, { exact: true }).count()) > 0) {
await page.getByRole('row', { name: databaseTableNameUpdated }).getByRole('button').click()
await page
.getByRole('row', { name: databaseTableNameUpdated })
.getByRole('button')
.last()
.click()
await page.getByRole('menuitem', { name: 'Delete table' }).click()
await page.getByRole('checkbox', { name: 'Drop table with cascade?' }).check()
await page.getByRole('button', { name: 'Delete' }).click()
@@ -204,6 +212,7 @@ test.describe.serial('Database', () => {
await page
.getByRole('row', { name: databaseTableNameDuplicate })
.getByRole('button')
.last()
.click()
await page.getByRole('menuitem', { name: 'Delete table' }).click()
await page.getByRole('checkbox', { name: 'Drop table with cascade?' }).check()
@@ -222,7 +231,7 @@ test.describe.serial('Database', () => {
await expect(page.getByText(databaseTableNameNew, { exact: true })).toBeVisible()
// edit a new table
await page.getByRole('row', { name: databaseTableNameNew }).getByRole('button').click()
await page.getByRole('row', { name: databaseTableNameNew }).getByRole('button').last().click()
await page.getByRole('menuitem', { name: 'Edit table' }).click()
await page.getByTestId('table-name-input').fill(databaseTableNameUpdated)
await page.getByRole('button', { name: 'Save' }).click()
@@ -233,7 +242,11 @@ test.describe.serial('Database', () => {
await expect(page.getByText(databaseTableNameUpdated, { exact: true })).toBeVisible()
// duplicate table
await page.getByRole('row', { name: databaseTableNameUpdated }).getByRole('button').click()
await page
.getByRole('row', { name: databaseTableNameUpdated })
.getByRole('button')
.last()
.click()
await page.getByRole('menuitem', { name: 'Duplicate Table' }).click()
await page.getByTestId('table-name-input').fill(databaseTableNameDuplicate)
await page.getByRole('textbox', { name: 'Optional' }).fill('')
@@ -248,6 +261,7 @@ test.describe.serial('Database', () => {
await page
.getByRole('row', { name: `${databaseTableNameDuplicate}` })
.getByRole('button')
.last()
.click()
await page.getByRole('menuitem', { name: 'Delete table' }).click()
await page.getByRole('checkbox', { name: 'Drop table with cascade?' }).check()
@@ -257,6 +271,7 @@ test.describe.serial('Database', () => {
await page
.getByRole('row', { name: `${databaseTableNameUpdated}` })
.getByRole('button')
.last()
.click()
await page.getByRole('menuitem', { name: 'Delete table' }).click()
await page.getByRole('checkbox', { name: 'Drop table with cascade?' }).check()
@@ -264,7 +279,7 @@ test.describe.serial('Database', () => {
await waitForApiResponse(page, 'pg-meta', ref, 'query?key=table-delete')
// validate navigating to table editor from database table page
await page.getByRole('row', { name: databaseTableName }).getByRole('button').click()
await page.getByRole('row', { name: databaseTableName }).getByRole('button').last().click()
await page.getByRole('menuitem', { name: 'View in Table Editor' }).click()
await page.waitForTimeout(1000) // wait for the table editor to be loaded
expect(page.url().includes('editor')).toBe(true)
@@ -468,7 +483,11 @@ test.describe.serial('Database', () => {
expect(page.getByText('confirmation_token_idx')).toBeVisible()
// check index definition
await page.getByRole('row', { name: 'confirmation_token_idx' }).getByRole('button').click()
await page
.getByRole('row', { name: 'confirmation_token_idx' })
.getByRole('button')
.last()
.click()
await page.getByText('Index:confirmation_token_idx')
await page.waitForTimeout(500) // wait for text content to be visible
expect(await page.getByRole('presentation').textContent()).toBe(
e2e/studio/features/table-editor.spec.ts
+10 -3
View File
@@ -196,14 +196,21 @@ test.describe.serial('table editor', () => {
// change schema from public to auth
await page.getByTestId('schema-selector').click()
await page.getByPlaceholder('Find schema...').fill('auth')
// Set up the waiter BEFORE clicking to avoid race condition
const tableLoadPromise = waitForTableToLoad(page, ref, 'auth')
await page.getByRole('option', { name: 'auth' }).click()
await waitForTableToLoad(page, ref, 'auth') // load auth tables
await tableLoadPromise // wait for auth tables to load
await expect(page.getByLabel(`View ${authTableSso}`)).toBeVisible()
await expect(page.getByLabel(`View ${authTableMfa}`)).toBeVisible()
// can find auth tables
// Search is client-side filtering - no API call needed
await page.getByRole('textbox', { name: 'Search tables...' }).fill('mfa')
await waitForTableToLoad(page, ref, 'auth') // load tables
// Wait for the UI to update after search (allow debounce to complete)
await page.waitForTimeout(300)
await expect(page.getByLabel(`View ${authTableSso}`)).not.toBeVisible()
await expect(page.getByLabel(`View ${authTableMfa}`)).toBeVisible()
})
e2e/studio/playwright.config.ts
+9 -10
View File
@@ -9,20 +9,15 @@ dotenv.config({
const IS_CI = !!process.env.CI
const webServerConfig = IS_CI
? undefined
: {
command: 'pnpm -w run e2e:setup',
port: 8082,
timeout: 5 * 60 * 1000,
}
const WEB_SERVER_TIMEOUT = Number(process.env.WEB_SERVER_TIMEOUT) || 10 * 60 * 1000
const WEB_SERVER_PORT = Number(process.env.WEB_SERVER_PORT) || 8082
export default defineConfig({
timeout: 90 * 1000,
timeout: 120 * 1000,
testDir: './features',
testMatch: /.*\.spec\.ts/,
forbidOnly: IS_CI,
retries: IS_CI ? 3 : 0,
retries: IS_CI ? 5 : 0,
maxFailures: 3,
fullyParallel: true,
use: {
@@ -61,5 +56,9 @@ export default defineConfig({
['html', { open: 'never' }],
['json', { outputFile: 'test-results/test-results.json' }],
],
webServer: webServerConfig,
webServer: {
command: 'pnpm --workspace-root run e2e:setup',
port: WEB_SERVER_PORT,
timeout: WEB_SERVER_TIMEOUT,
},
})