From 71a2888d0a141db80c27cae4c9cdf26ddd8c3bd4 Mon Sep 17 00:00:00 2001 From: Joshen Lim Date: Thu, 15 Dec 2022 02:17:24 +0700 Subject: [PATCH] Refresh views upon deleting column --- studio/pages/project/[ref]/editor/[id].tsx | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/studio/pages/project/[ref]/editor/[id].tsx b/studio/pages/project/[ref]/editor/[id].tsx index f1802bb62ad..e273343bcd9 100644 --- a/studio/pages/project/[ref]/editor/[id].tsx +++ b/studio/pages/project/[ref]/editor/[id].tsx @@ -127,12 +127,20 @@ const TableEditorPage: NextPage = () => { const onConfirmDeleteColumn = async () => { try { - const response: any = await meta.columns.del(selectedColumnToDelete!.id, isDeleteWithCascade) + if (selectedColumnToDelete === undefined) return + + const response: any = await meta.columns.del(selectedColumnToDelete.id, isDeleteWithCascade) if (response.error) throw response.error - removeDeletedColumnFromFiltersAndSorts(selectedColumnToDelete!.name) + removeDeletedColumnFromFiltersAndSorts(selectedColumnToDelete.name) + + ui.setNotification({ + category: 'success', + message: `Successfully deleted column "${selectedColumnToDelete.name}"`, + }) await meta.tables.loadById(selectedColumnToDelete!.table_id) + if (selectedSchema) await meta.schemas.loadViews(selectedSchema) } catch (error: any) { ui.setNotification({ category: 'error', @@ -146,7 +154,7 @@ const TableEditorPage: NextPage = () => { const onConfirmDeleteTable = async () => { try { - if (isUndefined(selectedTableToDelete)) return + if (selectedTableToDelete === undefined) return const response: any = await meta.tables.del(selectedTableToDelete.id, isDeleteWithCascade) if (response.error) throw response.error @@ -161,7 +169,7 @@ const TableEditorPage: NextPage = () => { } ui.setNotification({ category: 'success', - message: `Successfully deleted ${selectedTableToDelete.name}`, + message: `Successfully deleted table "${selectedTableToDelete.name}"`, }) if (selectedSchema) await meta.schemas.loadViews(selectedSchema) } catch (error: any) {