From 65185cd499c7fabd3e36ce694e01d15b731adfa8 Mon Sep 17 00:00:00 2001
From: Jordi Enric <jordi.err@gmail.com>
Date: Wed, 18 Jun 2025 12:20:03 +0200
Subject: [PATCH] reduce dupplicate code in reports date ranges

---
 .../WarehouseCollectionDetail.tsx             | 21 +++------
 .../interfaces/Reports/ReportFilterBar.tsx    | 25 +----------
 .../Settings/Logs/PreviewFilterPanel.tsx      | 11 +----
 apps/studio/data/reports/api-report-query.ts  | 44 ++++++++++++++++---
 .../data/reports/storage-report-query.ts      | 14 +++++-
 apps/studio/hooks/analytics/useLogsQuery.tsx  | 25 +++--------
 .../project/[ref]/reports/api-overview.tsx    | 23 +---------
 .../pages/project/[ref]/reports/storage.tsx   | 36 ++-------------
 8 files changed, 68 insertions(+), 131 deletions(-)

diff --git a/apps/studio/components/interfaces/DataWarehouse/WarehouseCollectionDetail.tsx b/apps/studio/components/interfaces/DataWarehouse/WarehouseCollectionDetail.tsx
index f0be4402a71..8bb2de4c156 100644
--- a/apps/studio/components/interfaces/DataWarehouse/WarehouseCollectionDetail.tsx
+++ b/apps/studio/components/interfaces/DataWarehouse/WarehouseCollectionDetail.tsx
@@ -22,22 +22,26 @@ import { TestCollectionDialog } from './TestCollectionDialog'
 
 const INTERVALS: DatetimeHelper[] = [
   {
+    id: 'last-hour',
     text: 'Last hour',
     calcFrom: () => dayjs().subtract(1, 'hour').toISOString(),
     calcTo: () => dayjs().toISOString(),
     default: true,
   },
   {
+    id: 'last-12-hours',
     text: 'Last 12 hours',
     calcFrom: () => dayjs().subtract(12, 'hour').toISOString(),
     calcTo: () => dayjs().toISOString(),
   },
   {
+    id: 'last-day',
     text: 'Last day',
     calcFrom: () => dayjs().subtract(1, 'day').toISOString(),
     calcTo: () => dayjs().toISOString(),
   },
   {
+    id: 'last-7-days',
     text: 'Last 7 days',
     calcFrom: () => dayjs().subtract(7, 'day').toISOString(),
     calcTo: () => dayjs().toISOString(),
@@ -202,22 +206,7 @@ order by timestamp desc limit ${filters.limit} offset ${filters.offset}
                 value={search}
                 onChange={(e) => setSearch(e.target.value)}
               /> */}
-              <LogsDatePicker
-                helpers={INTERVALS}
-                value={{
-                  from: filters.interval.from(),
-                  to: filters.interval.to(),
-                }}
-                onSubmit={(e) =>
-                  setFilters({
-                    ...filters,
-                    interval: {
-                      to: () => e.to || '',
-                      from: () => e.from || '',
-                    },
-                  })
-                }
-              />
+              <LogsDatePicker helpers={INTERVALS} />
             </form>
             <div className="flex items-center gap-2">
               <Tooltip>
diff --git a/apps/studio/components/interfaces/Reports/ReportFilterBar.tsx b/apps/studio/components/interfaces/Reports/ReportFilterBar.tsx
index 918bce39d8f..4f73e3c81ac 100644
--- a/apps/studio/components/interfaces/Reports/ReportFilterBar.tsx
+++ b/apps/studio/components/interfaces/Reports/ReportFilterBar.tsx
@@ -20,7 +20,7 @@ import {
   Select,
   cn,
 } from 'ui'
-import { DatePickerValue, LogsDatePicker } from '../Settings/Logs/Logs.DatePickers'
+import { LogsDatePicker } from '../Settings/Logs/Logs.DatePickers'
 import { REPORTS_DATEPICKER_HELPERS } from './Reports.constants'
 import type { ReportFilterItem } from './Reports.types'
 
@@ -30,9 +30,6 @@ interface ReportFilterBarProps {
   onAddFilter: (filter: ReportFilterItem) => void
   onRemoveFilters: (filters: ReportFilterItem[]) => void
   onRefresh: () => void
-  onDatepickerChange: ComponentProps<typeof LogsDatePicker>['onSubmit']
-  datepickerTo?: string
-  datepickerFrom?: string
   datepickerHelpers: typeof REPORTS_DATEPICKER_HELPERS
 }
 
@@ -83,7 +80,6 @@ const ReportFilterBar = ({
   filters,
   isLoading = false,
   onAddFilter,
-  onDatepickerChange,
   onRemoveFilters,
   onRefresh,
   datepickerHelpers,
@@ -117,11 +113,6 @@ const ReportFilterBar = ({
     })
   }
 
-  const handleDatepickerChange = (vals: DatePickerValue) => {
-    onDatepickerChange(vals)
-    setSelectedRange(vals)
-  }
-
   const handleProductFilterChange = async (
     nextProductFilter: null | (typeof PRODUCT_FILTERS)[number]
   ) => {
@@ -144,14 +135,6 @@ const ReportFilterBar = ({
     setCurrentProductFilter(nextProductFilter)
   }
 
-  const defaultHelper = datepickerHelpers[0]
-  const [selectedRange, setSelectedRange] = useState<DatePickerValue>({
-    to: defaultHelper.calcTo(),
-    from: defaultHelper.calcFrom(),
-    isHelper: true,
-    text: defaultHelper.text,
-  })
-
   return (
     <div className="flex items-center justify-between">
       <div className="flex flex-row justify-start items-center flex-wrap gap-2">
@@ -163,11 +146,7 @@ const ReportFilterBar = ({
           tooltip={{ content: { side: 'bottom', text: 'Refresh report' } }}
           onClick={() => onRefresh()}
         />
-        <LogsDatePicker
-          onSubmit={handleDatepickerChange}
-          value={selectedRange}
-          helpers={datepickerHelpers}
-        />
+        <LogsDatePicker helpers={datepickerHelpers} />
         <DropdownMenu>
           <DropdownMenuTrigger asChild>
             <Button
diff --git a/apps/studio/components/interfaces/Settings/Logs/PreviewFilterPanel.tsx b/apps/studio/components/interfaces/Settings/Logs/PreviewFilterPanel.tsx
index 292a316cd93..26be21b2814 100644
--- a/apps/studio/components/interfaces/Settings/Logs/PreviewFilterPanel.tsx
+++ b/apps/studio/components/interfaces/Settings/Logs/PreviewFilterPanel.tsx
@@ -65,8 +65,6 @@ const PreviewFilterPanel = ({
   table,
   onSelectedDatabaseChange,
   className,
-  selectedDatePickerValue,
-  setSelectedDatePickerValue,
 }: PreviewFilterPanelProps) => {
   const router = useRouter()
   const { ref } = useParams()
@@ -181,14 +179,7 @@ const PreviewFilterPanel = ({
           </TooltipContent>
         </Tooltip>
 
-        <LogsDatePicker
-          helpers={PREVIEWER_DATEPICKER_HELPERS}
-          onSubmit={(vals) => {
-            onSearch('datepicker-change', { to: vals.to, from: vals.from })
-            setSelectedDatePickerValue(vals)
-          }}
-          value={selectedDatePickerValue}
-        />
+        <LogsDatePicker helpers={PREVIEWER_DATEPICKER_HELPERS} />
 
         {FILTER_OPTIONS[table] !== undefined && (
           <div className="flex items-center">
diff --git a/apps/studio/data/reports/api-report-query.ts b/apps/studio/data/reports/api-report-query.ts
index b3a1605df39..aacd04cb95e 100644
--- a/apps/studio/data/reports/api-report-query.ts
+++ b/apps/studio/data/reports/api-report-query.ts
@@ -8,11 +8,13 @@ import { queriesFactory } from 'components/interfaces/Reports/Reports.utils'
 import type { LogsEndpointParams } from 'components/interfaces/Settings/Logs/Logs.types'
 import { useProjectContext } from 'components/layouts/ProjectLayout/ProjectContext'
 import { useDatabaseSelectorStateSnapshot } from 'state/database-selector'
+import { useLogsUrlState } from 'hooks/analytics/useLogsUrlState'
 
 export const useApiReport = () => {
   const { project } = useProjectContext()
   const { ref: projectRef } = useParams()
   const state = useDatabaseSelectorStateSnapshot()
+  const { timestampStart, timestampEnd } = useLogsUrlState()
 
   const identifier = state.selectedDatabaseId
   const [filters, setFilters] = useState<ReportFilterItem[]>([])
@@ -121,13 +123,41 @@ export const useApiReport = () => {
       networkTraffic: networkTraffic.logData,
     },
     params: {
-      totalRequests: totalRequests.params,
-      errorCounts: errorCounts.params,
-      responseSpeed: responseSpeed.params,
-      topRoutes: topRoutes.params,
-      topErrorRoutes: topErrorRoutes.params,
-      topSlowRoutes: topSlowRoutes.params,
-      networkTraffic: networkTraffic.params,
+      totalRequests: {
+        ...totalRequests.params,
+        iso_timestamp_start: timestampStart,
+        iso_timestamp_end: timestampEnd,
+      },
+      errorCounts: {
+        ...errorCounts.params,
+        iso_timestamp_start: timestampStart,
+        iso_timestamp_end: timestampEnd,
+      },
+      responseSpeed: {
+        ...responseSpeed.params,
+        iso_timestamp_start: timestampStart,
+        iso_timestamp_end: timestampEnd,
+      },
+      topRoutes: {
+        ...topRoutes.params,
+        iso_timestamp_start: timestampStart,
+        iso_timestamp_end: timestampEnd,
+      },
+      topErrorRoutes: {
+        ...topErrorRoutes.params,
+        iso_timestamp_start: timestampStart,
+        iso_timestamp_end: timestampEnd,
+      },
+      topSlowRoutes: {
+        ...topSlowRoutes.params,
+        iso_timestamp_start: timestampStart,
+        iso_timestamp_end: timestampEnd,
+      },
+      networkTraffic: {
+        ...networkTraffic.params,
+        iso_timestamp_start: timestampStart,
+        iso_timestamp_end: timestampEnd,
+      },
     },
     error: {
       totalRequest: totalRequests.error,
diff --git a/apps/studio/data/reports/storage-report-query.ts b/apps/studio/data/reports/storage-report-query.ts
index ff96099ba8f..11ecde8094a 100644
--- a/apps/studio/data/reports/storage-report-query.ts
+++ b/apps/studio/data/reports/storage-report-query.ts
@@ -4,9 +4,11 @@ import { useParams } from 'common'
 import { PRESET_CONFIG } from 'components/interfaces/Reports/Reports.constants'
 import { queriesFactory } from 'components/interfaces/Reports/Reports.utils'
 import type { LogsEndpointParams } from 'components/interfaces/Settings/Logs/Logs.types'
+import { useLogsUrlState } from 'hooks/analytics/useLogsUrlState'
 
 export const useStorageReport = () => {
   const { ref: projectRef } = useParams()
+  const { timestampStart, timestampEnd } = useLogsUrlState()
 
   const queryHooks = queriesFactory<keyof typeof PRESET_CONFIG.storage.queries>(
     PRESET_CONFIG.storage.queries,
@@ -43,8 +45,16 @@ export const useStorageReport = () => {
       topCacheMisses: topCacheMisses.logData,
     },
     params: {
-      cacheHitRate: cacheHitRate.params,
-      topCacheMisses: topCacheMisses.params,
+      cacheHitRate: {
+        ...cacheHitRate.params,
+        iso_timestamp_start: timestampStart,
+        iso_timestamp_end: timestampEnd,
+      },
+      topCacheMisses: {
+        ...topCacheMisses.params,
+        iso_timestamp_start: timestampStart,
+        iso_timestamp_end: timestampEnd,
+      },
     },
     mergeParams: handleSetParams,
     isLoading,
diff --git a/apps/studio/hooks/analytics/useLogsQuery.tsx b/apps/studio/hooks/analytics/useLogsQuery.tsx
index d893b380722..72f3c7abaae 100644
--- a/apps/studio/hooks/analytics/useLogsQuery.tsx
+++ b/apps/studio/hooks/analytics/useLogsQuery.tsx
@@ -16,6 +16,7 @@ import {
   checkForWithClause,
 } from 'components/interfaces/Settings/Logs/Logs.utils'
 import { get } from 'data/fetchers'
+import { useLogsUrlState } from 'hooks/analytics/useLogsUrlState'
 
 export interface LogsQueryHook {
   params: LogsEndpointParams
@@ -34,16 +35,13 @@ const useLogsQuery = (
   initialParams: Partial<LogsEndpointParams> = {},
   enabled = true
 ): LogsQueryHook => {
+  const { timestampStart, timestampEnd } = useLogsUrlState()
   const defaultHelper = getDefaultHelper(EXPLORER_DATEPICKER_HELPERS)
   const [params, setParams] = useState<LogsEndpointParams>({
     sql: initialParams?.sql || '',
     project: projectRef,
-    iso_timestamp_start: initialParams.iso_timestamp_start
-      ? initialParams.iso_timestamp_start
-      : defaultHelper.calcFrom(),
-    iso_timestamp_end: initialParams.iso_timestamp_end
-      ? initialParams.iso_timestamp_end
-      : defaultHelper.calcTo(),
+    iso_timestamp_start: timestampStart || initialParams.iso_timestamp_start || '',
+    iso_timestamp_end: timestampEnd || initialParams.iso_timestamp_end || '',
   })
 
   useEffect(() => {
@@ -52,19 +50,10 @@ const useLogsQuery = (
       ...initialParams,
       project: projectRef,
       sql: initialParams?.sql ?? prev.sql,
-      iso_timestamp_start: initialParams.iso_timestamp_start
-        ? initialParams.iso_timestamp_start
-        : defaultHelper.calcFrom(),
-      iso_timestamp_end: initialParams.iso_timestamp_end
-        ? initialParams.iso_timestamp_end
-        : defaultHelper.calcTo(),
+      iso_timestamp_start: timestampStart || initialParams.iso_timestamp_start || '',
+      iso_timestamp_end: timestampEnd || initialParams.iso_timestamp_end || '',
     }))
-  }, [
-    projectRef,
-    initialParams.sql,
-    initialParams.iso_timestamp_start,
-    initialParams.iso_timestamp_end,
-  ])
+  }, [projectRef, initialParams.sql, timestampStart, timestampEnd])
 
   const _enabled = enabled && typeof projectRef !== 'undefined' && Boolean(params.sql)
 
diff --git a/apps/studio/pages/project/[ref]/reports/api-overview.tsx b/apps/studio/pages/project/[ref]/reports/api-overview.tsx
index 16a527d3e06..61f06cd98f5 100644
--- a/apps/studio/pages/project/[ref]/reports/api-overview.tsx
+++ b/apps/studio/pages/project/[ref]/reports/api-overview.tsx
@@ -10,7 +10,6 @@ import {
   TopApiRoutesRenderer,
   TotalRequestsChartRenderer,
 } from 'components/interfaces/Reports/renderers/ApiRenderers'
-import type { DatePickerToFrom } from 'components/interfaces/Settings/Logs/Logs.types'
 import DefaultLayout from 'components/layouts/DefaultLayout'
 import ReportsLayout from 'components/layouts/ReportsLayout/ReportsLayout'
 import ShimmerLine from 'components/ui/ShimmerLine'
@@ -22,36 +21,16 @@ export const ApiReport: NextPageWithLayout = () => {
   const report = useApiReport()
   const organization = useSelectedOrganization()
 
-  const {
-    data,
-    error,
-    filters,
-    isLoading,
-    params,
-    mergeParams,
-    removeFilters,
-    addFilter,
-    refresh,
-  } = report
+  const { data, error, filters, isLoading, params, removeFilters, addFilter, refresh } = report
 
   const plan = organization?.plan
 
-  const handleDatepickerChange = ({ from, to }: DatePickerToFrom) => {
-    mergeParams({
-      iso_timestamp_start: from || '',
-      iso_timestamp_end: to || '',
-    })
-  }
-
   return (
     <ReportPadding>
       <ReportHeader title="API" />
       <div className="w-full flex flex-col gap-1">
         <ReportFilterBar
           onRemoveFilters={removeFilters}
-          onDatepickerChange={handleDatepickerChange}
-          datepickerFrom={params.totalRequests.iso_timestamp_start}
-          datepickerTo={params.totalRequests.iso_timestamp_end}
           onAddFilter={addFilter}
           onRefresh={refresh}
           isLoading={isLoading}
diff --git a/apps/studio/pages/project/[ref]/reports/storage.tsx b/apps/studio/pages/project/[ref]/reports/storage.tsx
index a2ece5db2f0..b9526cc8141 100644
--- a/apps/studio/pages/project/[ref]/reports/storage.tsx
+++ b/apps/studio/pages/project/[ref]/reports/storage.tsx
@@ -1,20 +1,12 @@
-import { useState } from 'react'
-
 import ReportHeader from 'components/interfaces/Reports/ReportHeader'
 import ReportPadding from 'components/interfaces/Reports/ReportPadding'
 import ReportWidget from 'components/interfaces/Reports/ReportWidget'
-import {
-  createFilteredDatePickerHelpers,
-  REPORTS_DATEPICKER_HELPERS,
-} from 'components/interfaces/Reports/Reports.constants'
+import { createFilteredDatePickerHelpers } from 'components/interfaces/Reports/Reports.constants'
 import {
   CacheHitRateChartRenderer,
   TopCacheMissesRenderer,
 } from 'components/interfaces/Reports/renderers/StorageRenderers'
-import {
-  DatePickerValue,
-  LogsDatePicker,
-} from 'components/interfaces/Settings/Logs/Logs.DatePickers'
+import { LogsDatePicker } from 'components/interfaces/Settings/Logs/Logs.DatePickers'
 import ReportsLayout from 'components/layouts/ReportsLayout/ReportsLayout'
 import { ButtonTooltip } from 'components/ui/ButtonTooltip'
 import ShimmerLine from 'components/ui/ShimmerLine'
@@ -32,26 +24,8 @@ export const StorageReport: NextPageWithLayout = () => {
 
   const plan = organization?.plan
 
-  const defaultHelper =
-    REPORTS_DATEPICKER_HELPERS.find((h) => h.default) || REPORTS_DATEPICKER_HELPERS[0]
-
-  const [selectedRange, setSelectedRange] = useState<DatePickerValue>({
-    to: defaultHelper.calcTo(),
-    from: defaultHelper.calcFrom(),
-    isHelper: true,
-    text: defaultHelper.text,
-  })
-
   const datepickerHelpers = createFilteredDatePickerHelpers(plan?.id || 'free')
 
-  const handleDatepickerChange = (vals: DatePickerValue) => {
-    report.mergeParams({
-      iso_timestamp_start: vals.from || '',
-      iso_timestamp_end: vals.to || '',
-    })
-    setSelectedRange(vals)
-  }
-
   return (
     <ReportPadding>
       <ReportHeader title="Storage" />
@@ -66,11 +40,7 @@ export const StorageReport: NextPageWithLayout = () => {
             onClick={() => refresh()}
           />
 
-          <LogsDatePicker
-            onSubmit={handleDatepickerChange}
-            value={selectedRange}
-            helpers={datepickerHelpers}
-          />
+          <LogsDatePicker helpers={datepickerHelpers} />
         </div>
 
         <div className="h-2 w-full">