From 24617670268aed578fd85cdbac12697c54de2646 Mon Sep 17 00:00:00 2001 From: Gildas Garcia <1122076+djhi@users.noreply.github.com> Date: Tue, 31 Mar 2026 13:58:14 +0200 Subject: [PATCH] fix inputs width and spacing (#44387) ## Problem #44282 introduced a change in design for inputs used outside a form layout such as search inputs on the project list page ## Solution Fix padding and spacing --- packages/ui-patterns/src/DataInputs/Input.tsx | 3 --- .../ui/src/components/shadcn/ui/input-group.tsx | 16 ++++++++-------- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/packages/ui-patterns/src/DataInputs/Input.tsx b/packages/ui-patterns/src/DataInputs/Input.tsx index 4200f05e70c..9b723c887c5 100644 --- a/packages/ui-patterns/src/DataInputs/Input.tsx +++ b/packages/ui-patterns/src/DataInputs/Input.tsx @@ -4,11 +4,9 @@ import React, { ComponentPropsWithoutRef, ElementRef, forwardRef, - useMemo, useState, } from 'react' import { - Button, cn, copyToClipboard, Input_Shadcn_, @@ -71,7 +69,6 @@ const Input = forwardRef< let inputClasses: string[] = [] if (size) inputClasses.push(__styles.size[size]) - if (icon) inputClasses.push(__styles.with_icon[size ?? 'small']) return ( diff --git a/packages/ui/src/components/shadcn/ui/input-group.tsx b/packages/ui/src/components/shadcn/ui/input-group.tsx index 343ad96e295..44057a3970e 100644 --- a/packages/ui/src/components/shadcn/ui/input-group.tsx +++ b/packages/ui/src/components/shadcn/ui/input-group.tsx @@ -13,8 +13,8 @@ function InputGroup({ className, ...props }: React.ComponentProps<'div'>) { role="group" className={cn( 'group/input-group relative items-center outline-none transition-[color,box-shadow]', - 'flex h-10 w-full rounded-md border border-control bg-foreground/[.026] py-2 text-sm', - 'h-9 has-[>textarea]:h-auto', + 'flex rounded-md border border-control bg-foreground/[.026] text-sm', + 'has-[>textarea]:h-auto', // Variants based on alignment. 'has-[>[data-align=inline-start]]:[&>input]:pl-2', @@ -42,16 +42,16 @@ function InputGroup({ className, ...props }: React.ComponentProps<'div'>) { } const inputGroupAddonVariants = cva( - "text-foreground-light flex h-auto cursor-text select-none items-center justify-center gap-2 py-1.5 text-sm group-data-[disabled=true]/input-group:opacity-50 [&>kbd]:rounded-[calc(var(--radius)-5px)] [&>svg:not([class*='size-'])]:size-4", + "text-foreground-light flex h-auto cursor-text select-none items-center justify-center gap-2 text-sm group-data-[disabled=true]/input-group:opacity-50 [&>kbd]:rounded-[calc(var(--radius)-5px)] [&>svg:not([class*='size-'])]:size-4", { variants: { align: { - 'inline-start': 'order-first pl-3 has-[>button]:ml-[-0.45rem] has-[>kbd]:ml-[-0.35rem]', - 'inline-end': 'order-last pr-3 has-[>button]:mr-[-0.4rem] has-[>kbd]:mr-[-0.35rem]', + 'inline-start': 'order-first pl-2 has-[>button]:ml-[-0.45rem] has-[>kbd]:ml-[-0.35rem]', + 'inline-end': 'order-last pr-2 has-[>button]:mr-[-0.4rem] has-[>kbd]:mr-[-0.35rem]', 'block-start': - '[.border-b]:pb-3 order-first w-full justify-start px-3 pt-3 group-has-[>input]/input-group:pt-2.5', + '[.border-b]:pb-3 order-first w-full justify-start px-2 pt-2 group-has-[>input]/input-group:pt-2.5', 'block-end': - '[.border-t]:pt-3 order-last w-full justify-start px-3 pb-3 group-has-[>input]/input-group:pb-2.5', + '[.border-t]:pt-3 order-last w-full justify-start px-2 pb-2 group-has-[>input]/input-group:pb-2.5', }, }, defaultVariants: { @@ -128,7 +128,7 @@ function InputGroupInput({ className, ...props }: InputProps) {