fix(studio): clarify RLS disable destructiveness (#46357)

## What kind of change does this PR introduce?

UI fix

## What is the current behavior?

RLS disable dialog is just plain prose.

## What is the new behavior?

RLS disable dialog better communicates the high-risk action.

| Before | After |
| --- | --- |
| <img width="866" height="536" alt="CleanShot 2026-05-26 at 11 31
47@2x"
src="https://github.com/user-attachments/assets/9ae061aa-edf5-45e8-b866-4d59a035a597"
/> | <img width="860" height="534" alt="CleanShot 2026-05-26 at 11 29
42@2x-584E1768-6ACD-4873-9477-A8FA7D017C67"
src="https://github.com/user-attachments/assets/00b485dd-485a-4c28-825c-6c0460e3428d"
/> |

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Refactor**
  * Improved RLS toggle dialog component logic.

* **Tests**
  * Enhanced RLS policies test assertions for better accuracy.

<!-- review_stack_entry_start -->

[![Review Change
Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/supabase/supabase/pull/46357?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)

<!-- review_stack_entry_end -->

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
This commit is contained in:
Danny White authored and GitHub committed 2026-05-26 18:46:24 +10:00
1 parent 3c2255c27c
commit 239825e9a3
2 files changed
+26 -14

No files matched your search

+10 -3
View File
@@ -160,10 +160,17 @@ test.describe('RLS Policies', () => {
'RLS disable confirmation modal should appear'
).toBeVisible({ timeout: 50000 })
await expect(
page.getByText(
'This table will become publicly readable and writable. Anyone can view, add, update, or delete data in this table, and existing RLS policies will no longer apply.'
),
page.getByRole('alertdialog'),
'RLS disable confirmation should explain the access risk'
).toContainText(
'This table will become publicly readable and writable. Anyone can view, add, update, or delete data in this table, and existing RLS policies will no longer apply.'
)
await expect(
page
.getByRole('alertdialog')
.locator('span.font-medium.text-foreground')
.filter({ hasText: 'Anyone can view, add, update, or delete data in this table' }),
'Key risk phrase should be visually emphasized'
).toBeVisible()
await expect(
page.getByRole('alertdialog').getByRole('link', { name: 'Learn more' })