diff --git a/packages/ui-patterns/src/FilterBar/CommandListItem.tsx b/packages/ui-patterns/src/FilterBar/CommandListItem.tsx index c420640469a..8c05ebb985b 100644 --- a/packages/ui-patterns/src/FilterBar/CommandListItem.tsx +++ b/packages/ui-patterns/src/FilterBar/CommandListItem.tsx @@ -1,4 +1,3 @@ -import { Check } from 'lucide-react' import { cn } from 'ui' import { OperatorSymbolBadge } from './OperatorSymbolBadge' @@ -7,7 +6,6 @@ import { MenuItem } from './types' export type CommandListItemProps = { item: MenuItem isHighlighted: boolean - isSelected: boolean includeIcon: boolean onSelect: (item: MenuItem) => void setRef: (el: HTMLDivElement | null) => void @@ -16,7 +14,6 @@ export type CommandListItemProps = { export function CommandListItem({ item, isHighlighted, - isSelected, includeIcon, onSelect, setRef, @@ -25,7 +22,6 @@ export function CommandListItem({
onSelect(item)} className={cn( 'relative flex items-center justify-between gap-2 px-2 py-1.5 text-xs cursor-pointer select-none outline-none text-foreground-light', @@ -37,10 +33,7 @@ export function CommandListItem({ {includeIcon && item.icon} {item.label} - - {item.operatorSymbol && } - {isSelected && } - + {item.operatorSymbol && }
) } diff --git a/packages/ui-patterns/src/FilterBar/DefaultCommandList.helpers.tsx b/packages/ui-patterns/src/FilterBar/DefaultCommandList.helpers.tsx index 7f75ff009ca..7a507adc69f 100644 --- a/packages/ui-patterns/src/FilterBar/DefaultCommandList.helpers.tsx +++ b/packages/ui-patterns/src/FilterBar/DefaultCommandList.helpers.tsx @@ -4,7 +4,7 @@ export function EmptyState() { export function GroupHeader({ label }: { label: string }) { return ( -
+
{label}
) diff --git a/packages/ui-patterns/src/FilterBar/DefaultCommandList.tsx b/packages/ui-patterns/src/FilterBar/DefaultCommandList.tsx index 09d5065ac6d..761019dfc25 100644 --- a/packages/ui-patterns/src/FilterBar/DefaultCommandList.tsx +++ b/packages/ui-patterns/src/FilterBar/DefaultCommandList.tsx @@ -13,7 +13,6 @@ export type DefaultCommandListProps = { onSelect: (item: MenuItem) => void includeIcon?: boolean grouped?: boolean - selectedValue?: string } export function DefaultCommandList({ @@ -22,7 +21,6 @@ export function DefaultCommandList({ onSelect, includeIcon = true, grouped = false, - selectedValue, }: DefaultCommandListProps) { const listRef = useRef(null) const itemRefs = useRef>(new Map()) @@ -78,7 +76,6 @@ export function DefaultCommandList({ key={`${item.value}-${item.label}`} item={item} isHighlighted={index === highlightedIndex} - isSelected={selectedValue === item.value} includeIcon={includeIcon} onSelect={onSelect} setRef={setItemRef(index)} diff --git a/packages/ui-patterns/src/FilterBar/FilterCondition.tsx b/packages/ui-patterns/src/FilterBar/FilterCondition.tsx index 27e7637b590..1c10369aae1 100644 --- a/packages/ui-patterns/src/FilterBar/FilterCondition.tsx +++ b/packages/ui-patterns/src/FilterBar/FilterCondition.tsx @@ -260,7 +260,6 @@ export function FilterCondition({ highlightedIndex={opHighlightedIndex} onSelect={handleSelectMenuItem} includeIcon={false} - selectedValue={condition.operator} grouped /> diff --git a/packages/ui-patterns/src/FilterBar/OperatorSymbolBadge.tsx b/packages/ui-patterns/src/FilterBar/OperatorSymbolBadge.tsx index d0788fd7b28..1870be99c0b 100644 --- a/packages/ui-patterns/src/FilterBar/OperatorSymbolBadge.tsx +++ b/packages/ui-patterns/src/FilterBar/OperatorSymbolBadge.tsx @@ -4,7 +4,7 @@ export type OperatorSymbolBadgeProps = { export function OperatorSymbolBadge({ symbol }: OperatorSymbolBadgeProps) { return ( - + {symbol} )