From 060bf2dfe55c79f9c05ca42dfa29a025819c2aec Mon Sep 17 00:00:00 2001 From: Jonathan Summers-Muir Date: Tue, 22 Apr 2025 15:46:13 +0800 Subject: [PATCH] encoding --- apps/studio/components/grid/hooks/useTableColumnOrder.ts | 6 ++++-- .../components/grid/hooks/useTableColumnVisibility.ts | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/apps/studio/components/grid/hooks/useTableColumnOrder.ts b/apps/studio/components/grid/hooks/useTableColumnOrder.ts index e86a5c1b0bc..06bec1ddf45 100644 --- a/apps/studio/components/grid/hooks/useTableColumnOrder.ts +++ b/apps/studio/components/grid/hooks/useTableColumnOrder.ts @@ -41,7 +41,8 @@ export function useTableColumnOrder() { }) // 2. Update URL Parameter - const newUrlString = newOrder.join(',') + // Encode commas for consistency + const newUrlString = newOrder.join('%2C') setParams((prevParams) => ({ ...prevParams, col_order: newUrlString || undefined, @@ -89,7 +90,8 @@ export function useTableColumnOrder() { } // Update URL Parameter with the locally calculated order - const newUrlString = newOrder.join(',') + // Encode commas for consistency + const newUrlString = newOrder.join('%2C') setParams((prevParams) => ({ ...prevParams, col_order: newUrlString || undefined, diff --git a/apps/studio/components/grid/hooks/useTableColumnVisibility.ts b/apps/studio/components/grid/hooks/useTableColumnVisibility.ts index 47bc7fb4be5..ae3846af389 100644 --- a/apps/studio/components/grid/hooks/useTableColumnVisibility.ts +++ b/apps/studio/components/grid/hooks/useTableColumnVisibility.ts @@ -44,7 +44,7 @@ export function useTableColumnVisibility() { const currentHidden = new Set(hiddenColumnsSet) currentHidden.add(columnName) const newHiddenArray = Array.from(currentHidden).sort() - const newUrlString = newHiddenArray.join(',') + const newUrlString = newHiddenArray.join('%2C') setParams((prev) => ({ ...prev, hidden_cols: newUrlString || undefined })) }, [snap, setParams, hiddenColumnsSet] // Depend on snap, setParams, and current hidden set @@ -68,7 +68,7 @@ export function useTableColumnVisibility() { const currentHidden = new Set(hiddenColumnsSet) currentHidden.delete(columnName) const newHiddenArray = Array.from(currentHidden).sort() - const newUrlString = newHiddenArray.join(',') + const newUrlString = newHiddenArray.join('%2C') setParams((prev) => ({ ...prev, hidden_cols: newUrlString || undefined })) }, [snap, setParams, hiddenColumnsSet] // Depend on snap, setParams, and current hidden set