From 073fb4558030c2d2dbe01b1bf4dc06b8698a5318 Mon Sep 17 00:00:00 2001 From: Ivan Enderlin Date: Tue, 14 Jun 2022 09:41:03 +0200 Subject: [PATCH] feat(crypto-nodejs): Define Node.js versions policy. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We now support only “current”, “active” or “maintenance” versions according to https://nodejs.org/en/about/releases/, which are compatible with NAPI v6. --- .github/workflows/ci.yml | 4 ++-- crates/matrix-sdk-crypto-nodejs/README.md | 13 ++++++++----- crates/matrix-sdk-crypto-nodejs/package.json | 2 +- 3 files changed, 11 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1a58e55f3..7d00586b2 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -128,9 +128,9 @@ jobs: strategy: fail-fast: true matrix: - node-version: [14.0, 15.0, 16.0] + node-version: [14.0, 16.0, 18.0] include: - - node-version: 16.0 + - node-version: 18.0 build-doc: true steps: diff --git a/crates/matrix-sdk-crypto-nodejs/README.md b/crates/matrix-sdk-crypto-nodejs/README.md index a7b8d8f9f..10a6d321a 100644 --- a/crates/matrix-sdk-crypto-nodejs/README.md +++ b/crates/matrix-sdk-crypto-nodejs/README.md @@ -18,11 +18,14 @@ pretty classical by using [npm], see [the Downloading and installing Node.js and npm Page](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm). -The binding is using NAPI 6 (Node API version 6), which means that is -compatible with Node.js versions 14.0.0, 15.0.0 and 16.0.0 (see [the -full Node API version -matrix](https://nodejs.org/api/n-api.html#node-api-version-matrix)) -(we do not support the versions 10.20 and 12.17.0). +The binding is compatible with, and tested against, the Node.js +versions that are in “current”, “active” or “maintenance” states, +according to [the Node.js Releases +Page](https://nodejs.org/en/about/releases/), _and_ which are +compatible with [NAPI v6 (Node.js +API)](https://nodejs.org/api/n-api.html#node-api-version-matrix). It +means that this binding will work with the following versions: 14.0.0, +16.0.0 and 18.0.0. Once the Rust compiler, Node.js and npm are installed, you can run the following commands: diff --git a/crates/matrix-sdk-crypto-nodejs/package.json b/crates/matrix-sdk-crypto-nodejs/package.json index f0ae76922..e83ba25e9 100644 --- a/crates/matrix-sdk-crypto-nodejs/package.json +++ b/crates/matrix-sdk-crypto-nodejs/package.json @@ -18,7 +18,7 @@ "typedoc": "^0.22.17" }, "engines": { - "node": ">= 10" + "node": ">= 14" }, "scripts": { "build": "napi build --platform --release --strip",