Hubert Chathi
55ecb40190
don't keep processing if we have an error
2020-01-07 11:25:30 -05:00
Hubert Chathi
01f6b3dfc6
notify devices when we don't send them keys ( #1135 )
...
and handle incoming notifications
2020-01-06 17:47:22 -05:00
Michael Telatynski
64fb79e0be
Merge pull request #1141 from matrix-org/t3chguy/fuzzier_disambiguate
...
Make displayName disambiguation more fuzzy especially against RTL/LTR content
2020-01-06 13:12:39 +00:00
Michael Telatynski
088ff5d0aa
Merge pull request #1129 from matrix-org/t3chguy/m_too_large
...
stop trying to resend event if we get M_TOO_LARGE
2020-01-06 11:42:27 +00:00
Michael Telatynski
99e58b0297
Make displayName disambiguation more fuzzy especially against RTL/LTR content
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com >
2020-01-05 19:40:04 +00:00
David Baker
f8a1e98de1
Merge pull request #1139 from matrix-org/dbkr/fix_create_key_backup_crosssigning_disabled
...
Fix creating a key backup with cross signing diabled
2020-01-03 14:52:16 +00:00
David Baker
5487cf2070
Fix callback check
...
We need to check for getCrossSisgningKey but that was added
unconditionally elsewhere - only add it if we actually have a
getSecretStorageKey callback to use.
2020-01-03 14:36:04 +00:00
J. Ryan Stinnett
e998be3a9b
Fix typos in comments
2020-01-03 14:21:10 +00:00
David Baker
fbb355c5c9
Thank you once again, o great linter, for saving our lines from being too long
2020-01-03 14:02:38 +00:00
David Baker
20bc8071fc
Fix creating a key backup with cross signing diabled
...
It broke if no scret key callback was supplied but a cross-signing
identity did exist (as hopefully explained in comment).
Fixes https://github.com/vector-im/riot-web/issues/11763
2020-01-03 13:52:36 +00:00
David Baker
0438c6c51c
Oh great linter, your wisdom knows no bounds.
2020-01-03 13:37:55 +00:00
David Baker
b39abba41e
Use checkDeviceTrust with key backup
...
We did check if it was signed with a cross signing key which should
be the norm going forward, but for completeness, use the proper
cross-signing ernabled check for sigs from individual devices too.
Also adds a deviceTrust member to the signature so the app can see
the cross-signing trust status ofthe device without having to
recalculate it.
2020-01-03 13:32:31 +00:00
David Baker
320ab050fe
Stray p
2019-12-19 17:28:07 +00:00
David Baker
1816d7aa4c
comment
2019-12-19 17:27:15 +00:00
David Baker
41b763f331
Just get the private key from the decryption object
2019-12-19 17:25:28 +00:00
Michael Telatynski
36db57615d
stop retrying to send event if we get M_TOO_LARGE
2019-12-19 13:21:05 +00:00
David Baker
8f7ed1dc15
Lint
2019-12-19 11:50:25 +00:00
David Baker
83a8a0cf21
Add support for passthrough SSSS secrets
...
So we can migrate key backup keys
Adding a passthrough secret itself isn't exposed outside of the
js-sdk: hopefully this should only ever be necessary for this
bootstrap process which the js-sdk handles.
2019-12-19 11:23:57 +00:00
J. Ryan Stinnett
049b769f68
Add docs
2019-12-12 17:27:01 +00:00
J. Ryan Stinnett
1fc2ab7f7d
Fix backup tests
2019-12-12 16:06:46 +00:00
J. Ryan Stinnett
f2c5b2bd49
Emit user trust via the client
2019-12-12 15:41:56 +00:00
J. Ryan Stinnett
f31f88ce31
Merge remote-tracking branch 'origin/develop' into jryans/4s-new-key-backup
2019-12-12 15:38:32 +00:00
J. Ryan Stinnett
d35f5152a9
Restore key backup from stored key
2019-12-12 15:11:48 +00:00
J. Ryan Stinnett
d8e19db8bf
Merge pull request #1117 from matrix-org/jryans/rm-user-verif-event
...
Remove unused user verification event
2019-12-12 15:06:13 +00:00
J. Ryan Stinnett
376e56d5fd
Guard free calls
2019-12-12 14:49:49 +00:00
J. Ryan Stinnett
72f856eca4
Add util to check whether backup key is stored
2019-12-12 14:46:40 +00:00
J. Ryan Stinnett
dbab75eae7
Report cross-signing sig as JS style boolean
2019-12-12 13:25:03 +00:00
J. Ryan Stinnett
7457da80e9
Clean up backup trust checks
...
There were several inaccurate comments and redundant code paths around backup
trust checks.
2019-12-12 13:18:34 +00:00
J. Ryan Stinnett
443e01d38c
Always check backup validity, even during enabling
...
This ensure we run the full backup validity check even when enabling (rather
than assuming we've signed things correctly) to ensure any problem are reported
right away.
2019-12-12 13:15:32 +00:00
J. Ryan Stinnett
880438c5c1
Remove unused user verification event
...
This was added with cross-signing work, but nothing actually emits it. Let's
remove it until we find a need.
2019-12-12 12:13:40 +00:00
J. Ryan Stinnett
3f448df1d3
Create key backup with secret storage
...
When secret storage is enable, create a random key for encrypting key backups
and store it in SSSS.
2019-12-11 16:29:02 +00:00
J. Ryan Stinnett
a626b44bbe
Fix check for private keys
...
This check for new keys was always true, instead of checking whether something
was added.
2019-12-11 14:58:57 +00:00
J. Ryan Stinnett
657e48de7e
Fix grammar
2019-12-11 10:51:12 +00:00
J. Ryan Stinnett
1b63cb1406
Merge remote-tracking branch 'origin/develop' into jryans/4s-new-key-backup
2019-12-11 10:09:29 +00:00
Travis Ralston
9b8b57d186
Convert randomstring to typescript as a proof of concept
2019-12-10 11:50:01 -07:00
J. Ryan Stinnett
780394b051
Merge remote-tracking branch 'origin/develop' into jryans/4s-new-key-backup
2019-12-10 17:54:02 +00:00
J. Ryan Stinnett
6942e3467b
Rework to hold cross-signing keys in JS SDK as needed
2019-12-10 17:36:35 +00:00
Michael Telatynski
70eb8a7300
Merge pull request #1100 from matrix-org/t3chguy/remove_bluebird_13
...
Remove Bluebird: phase 2.5
2019-12-10 16:58:22 +00:00
Hubert Chathi
49f0e368d0
Merge pull request #1104 from matrix-org/uhoreg/ignore_verification_done
...
ignore m.key.verification.done messages when we don't expect any more messages
2019-12-10 09:27:22 -05:00
Bruno Windels
202fec2a35
dont cancel on remote echo of own .request event
2019-12-10 14:35:17 +01:00
Michael Telatynski
110c9800f0
Merge branches 't3chguy/remove_bluebird_12' and 't3chguy/remove_bluebird_13' of github.com:matrix-org/matrix-js-sdk into t3chguy/remove_bluebird_12
2019-12-10 00:19:03 +00:00
Michael Telatynski
1a6dc973bb
Merge branches 'develop' and 't3chguy/remove_bluebird_13' of github.com:matrix-org/matrix-js-sdk into t3chguy/remove_bluebird_13
2019-12-10 00:18:32 +00:00
J. Ryan Stinnett
44dd674dab
Note about static potential
2019-12-09 17:57:24 +00:00
J. Ryan Stinnett
4a3ce640d7
Document verification methods accepts cross-signing key ID as well
2019-12-09 17:20:54 +00:00
Bruno Windels
e5dcc5a407
use verification request with channel from crypto
2019-12-09 17:45:01 +01:00
Bruno Windels
1ee8abb0e6
wrap channel passed to verifier to nofity request
...
so request is notified when verifier sends an event
2019-12-09 17:45:01 +01:00
Bruno Windels
dd40435425
make verifier use channel instead of client straight away
...
so it is agnostic of the channel used
2019-12-09 17:45:01 +01:00
Bruno Windels
74cb57c761
extract DM verification specific things into InRoomChannel
2019-12-09 17:45:01 +01:00
Bruno Windels
86123f28f7
extract to_device verification specific things into ToDeviceChannel
2019-12-09 17:45:01 +01:00
Bruno Windels
f97ab32e7c
extract common logic between normal & DM verif into single request class
2019-12-09 17:45:01 +01:00