nchamo
7ea09ebe4a
Add fix and test
...
Signed-off-by: Nicolas Chamo <nicolas@chamo.com.ar >
2020-04-17 19:37:33 -03:00
David Baker
83b33d9d7a
Add a catch so the error doesn't propagate to later decryptions
2020-04-17 18:03:15 +01:00
David Baker
83879fa945
Serialise Olm prekey decryptions
...
If they overlap, they can both try to create new sessions, but this
removes the OTK so it will only work once.
Fixes https://github.com/vector-im/riot-web/issues/13229
2020-04-17 17:47:46 +01:00
Bruno Windels
57233416d9
Merge pull request #1324 from matrix-org/bwindels/fixkeybackupcrash
...
Fix: crash when backup key needs fixing from corruption issue
2020-04-17 12:11:07 +00:00
Bruno Windels
f56ce29210
method is on crypto
2020-04-17 13:51:12 +02:00
David Baker
da8ed77aae
lint
2020-04-16 20:18:27 +01:00
David Baker
12f46909f7
Fix cross-signing/SSSS reset
...
We re-used the old SSSS key even when resetting, meaning we prompted
the user to create a new passphrase but then ignored it and kept using
the old one.
Fixes https://github.com/vector-im/riot-web/issues/13212
2020-04-16 20:13:18 +01:00
Bruno Windels
f814a96eac
update comments
2020-04-16 14:30:51 +02:00
Bruno Windels
218aa423c3
implement qr code reciprocate for self-verif with untrusted MSK
2020-04-16 13:01:46 +02:00
Bruno Windels
d59d62f96a
Merge pull request #1318 from matrix-org/bwindels/fixindexernotifs
...
Fix: prevent spurious notifications from indexer
2020-04-15 16:50:18 +00:00
Bruno Windels
8a460c2368
fix jsdoc
2020-04-15 18:33:55 +02:00
Bruno Windels
6f60183316
allow creating event mappers that map events whose events are not reemitted
2020-04-15 17:08:25 +02:00
J. Ryan Stinnett
1b8f6d1739
Always create our own user object
...
This ensures our own user object is always available for tasks like
verification, even if you aren't in any rooms.
Fixes https://github.com/vector-im/riot-web/issues/13165
2020-04-14 16:02:00 +01:00
Hubert Chathi
e087bce61a
Merge pull request #1311 from matrix-org/uhoreg/fix_backup_key_format
...
Fix incorrect backup key format in SSSS
2020-04-13 17:38:45 -04:00
Bruno Windels
197d5ebb44
fix e2ee crash after refreshing after cross-singing key reset
2020-04-10 10:37:12 +02:00
Hubert Chathi
4039498eee
use cached backup key if available
2020-04-09 17:05:01 -04:00
Bruno Windels
a686231a5b
Merge pull request #1314 from matrix-org/bwindels/catchverifysenderrors
...
Fix: catch send errors in SAS verifier
2020-04-09 16:32:09 +00:00
Bruno Windels
11727833a2
mark request as cancelled immediately after verifier is cancelled
...
in case send errors prevent us from receiving remote echo
2020-04-09 17:54:45 +02:00
Hubert Chathi
df38fde336
apply changes from code review
2020-04-09 11:48:58 -04:00
Bruno Windels
00233d610b
pass on send errors so request gets cancelled
2020-04-09 17:23:44 +02:00
Bruno Windels
70071eef41
also emit user trust has changed
2020-04-09 14:09:51 +02:00
Bruno Windels
65dd56f53a
remove obsolete comment
2020-04-09 13:27:13 +02:00
Bruno Windels
c8fb4af369
fix comment style
2020-04-09 13:13:17 +02:00
Bruno Windels
9e1ba992e3
Clear cross-signing keys when detecting the keys have changed
2020-04-09 12:24:29 +02:00
Hubert Chathi
5bd146bb85
lint
2020-04-09 00:21:31 -04:00
Hubert Chathi
75703f273f
fix unit tests
2020-04-09 00:18:21 -04:00
Hubert Chathi
ca7b49d209
fix incorrect backup key format in SSSS
2020-04-09 00:08:17 -04:00
J. Ryan Stinnett
84637c6ebd
Merge pull request #1308 from matrix-org/jryans/backup-key-cache-format
...
Store key backup key in cache as Uint8Array
2020-04-08 11:32:18 +01:00
J. Ryan Stinnett
2ed6e9ba2f
Convert recovery key to Uint8Array explicitly
2020-04-08 00:43:52 +01:00
J. Ryan Stinnett
2e3cb54d38
Restore redundant conversion for tests
2020-04-07 19:21:25 +01:00
J. Ryan Stinnett
0efac7eae0
Store key backup key in cache as Uint8Array
...
Bootstrap was incorrectly storing the key backup key as base64 encoded, when
instead it should be a uint8Array.
Fixes https://github.com/vector-im/riot-web/issues/13057
2020-04-07 18:28:48 +01:00
J. Ryan Stinnett
dc56f05d03
Throw error when trying to cache keys in the wrong format
2020-04-07 18:06:57 +01:00
Hubert Chathi
4d2625278c
Merge pull request #1307 from MTRNord/fix-keys_query_endpoint
...
Use the correct request body for the /keys/query endpoint.
2020-04-07 12:01:06 -04:00
Marcel
1b3c4c935e
Use the correct request body for the /keys/query endpoint.
...
https://matrix.org/docs/spec/client_server/r0.6.0#post-matrix-client-r0-keys-query
2020-04-07 14:08:49 +02:00
David Baker
66417e6742
Merge pull request #1305 from matrix-org/dbkr/uia_ignore_poll_after_success
...
Avoid creating two devices on registration
2020-04-07 10:32:08 +01:00
David Baker
6ad4d6dd62
also fix typo
2020-04-07 10:21:57 +01:00
David Baker
59607f8dbf
Clear resolve / reject function after rejecting too
2020-04-07 10:20:58 +01:00
David Baker
964a448470
Avoid creating two devices on registration
...
Ignore poll requests after a UIA session has finished. Sometimes
the app calls poll() even after the registration has succeeded
which causes the API call to happen again which, in the case of
registration, creates a phantom device.
Fixes https://github.com/vector-im/riot-web/issues/13040
2020-04-06 19:45:18 +01:00
J. Ryan Stinnett
060549656e
Move key backup key creation before caching
...
For some reason, we were trying to cache the key backup key before it was
created, and as a result we wouldn't cache the key until perhaps a second time
through bootstrapping.
Fixes https://github.com/vector-im/riot-web/issues/13023
2020-04-06 16:03:24 +01:00
Zoe
7dabf507a2
Merge pull request #1298 from matrix-org/foldleft/12843-resend-requests
...
Expose function to force-reset outgoing room key requests
2020-04-06 13:43:06 +01:00
Zoe
d69afa47a1
review feedback
2020-04-06 13:30:36 +01:00
Zoe
b8bc323c03
add a crypto-level function for resending key requests
2020-04-03 11:47:13 +01:00
Zoe
c6d32ea2b0
Expose function to force-reset outgoing room key requests
2020-04-02 16:25:50 +01:00
Bruno Windels
2ace35ad6b
add isSelfVerification helper
2020-04-02 17:16:06 +02:00
Bruno Windels
b5ea8d3a78
Merge branch 'bwindels/qr-reciprocate' into bwindels/selfverifux
2020-04-02 17:15:32 +02:00
Bruno Windels
f3a05f6ed0
fix jsdoc
2020-04-02 13:37:15 +02:00
Bruno Windels
43eae4929b
remove ts annotations as I don't want to convert the whole file now
2020-04-02 13:31:17 +02:00
Bruno Windels
6144962c24
cancel with m.user code when user doesn't reciprocate
2020-04-02 12:53:52 +02:00
Bruno Windels
544cc36006
explain a bit why we're doing things here
2020-04-02 11:31:44 +02:00
Hubert Chathi
1834e6688f
Merge pull request #1294 from matrix-org/uhoreg/check_sssss_passphrase
...
Add ability to check symmetric SSSS key before we try to use it
2020-04-01 16:01:34 -04:00