From e84c90dbbc9bab724ea2fbf6cd475cb5d26c0177 Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Tue, 7 Mar 2023 14:23:56 +0000 Subject: [PATCH] Add GHA for requiring all reviews to be dismissed or approving before merging (#2391) * Add GHA for requiring all reviews to be dismissed or approving before merging * Attempt again * Try try try again * stash * Stash * Dummy * Fix indentation * Iterate * Tweak * Iterate * toJSON * Iterate * Iterate * Fix * typo * Permissions * tidy * Update pending_reviews.yml * delint --- .github/workflows/pending_reviews.yml | 46 +++++++++++++++++++++++++++ 1 file changed, 46 insertions(+) create mode 100644 .github/workflows/pending_reviews.yml diff --git a/.github/workflows/pending_reviews.yml b/.github/workflows/pending_reviews.yml new file mode 100644 index 000000000..858f48545 --- /dev/null +++ b/.github/workflows/pending_reviews.yml @@ -0,0 +1,46 @@ +name: Pending Reviews +on: + pull_request: + types: [opened, synchronize, review_requested, review_request_removed, ready_for_review] + pull_request_review: + types: [submitted, dismissed] + workflow_call: {} +concurrency: ${{ github.workflow }}-${{ github.event.workflow_run.head_branch }} +jobs: + reviews: + name: Assert no outstanding reviews + runs-on: ubuntu-latest + permissions: + pull-requests: read + statuses: write + steps: + - name: 🔍 Check reviewers + uses: actions/github-script@v5 + with: + script: | + const { owner, repo } = context.repo; + const pull = context.payload.pull_request; + const pull_number = pull.number; + const { data: reviews } = await github.rest.pulls.listReviews({ + pull_number, + owner, + repo, + }); + + const latestReviews = {}; + reviews.forEach(review => { + latestReviews[review.user.login] = review; + }); + + const pending = pull.requested_reviewers.length + || pull.requested_teams.length + || Object.values(latestReviews).some(r => !["APPROVED", "DISMISSED"].includes(r.state)); + + await github.rest.repos.createCommitStatus({ + context: "Pending reviews", + sha: pull.head.sha, + state: pending ? "failure" : "success", + description: pending ? "Outstanding pending reviews" : undefined, + owner, + repo, + });