Richard van der Hoff
f25fbdebc7
Modal: remove support for onFinished callback ( #29852 )
...
* Fix up type for `finished` result of Modal
The `finished` promise can be called with an empty array, for example if the
dialog is closed by a background click. This was not correctly represented in
the typing. Fix that, and add some documentation while we're at it.
* Type fixes to onFinished callbacks from Modal
These can all be called with zero arguments, despite what the type annotations
may say, so mark them accordingly.
* Remove uses of Modal `onFinished` property
... because it is confusing.
Instead, use the `finished` promise returned by `createDialog`.
* Modal: remove support for now-unused `onFinished` prop
* StopGapWidgetDriver: use `await` instead of promise chaining
* Fix up unit tests
2025-04-30 16:56:21 +01:00
..
2025-04-24 12:31:37 +00:00
2025-04-24 12:31:37 +00:00
2025-02-05 13:25:06 +00:00
2025-04-30 16:56:21 +01:00
2025-04-29 10:40:18 +00:00
2025-04-24 12:31:37 +00:00
2025-04-30 16:56:21 +01:00
2025-04-24 12:31:37 +00:00
2025-02-06 23:54:18 +00:00
2025-04-30 11:23:35 +00:00
2025-02-05 13:25:06 +00:00
2025-02-05 13:25:06 +00:00
2025-01-06 11:18:54 +00:00
2025-04-24 12:31:37 +00:00
2025-04-30 11:23:35 +00:00
2025-04-30 11:23:35 +00:00
2025-02-05 13:25:06 +00:00
2025-02-05 13:25:06 +00:00
2025-02-05 13:25:06 +00:00
2025-03-28 20:34:32 +00:00
2025-03-28 10:07:41 +00:00
2025-02-05 13:25:06 +00:00
2025-01-06 11:18:54 +00:00
2025-03-06 08:38:41 +00:00
2025-03-28 10:36:10 +00:00
2025-02-05 13:25:06 +00:00
2025-01-06 11:18:54 +00:00
2025-04-22 09:37:47 +00:00
2025-04-30 16:56:21 +01:00
2025-04-30 16:56:21 +01:00
2025-04-30 16:56:21 +01:00
2025-01-06 11:18:54 +00:00
2025-04-30 16:56:21 +01:00
2025-04-28 15:46:05 +00:00
2025-04-09 19:03:09 +00:00
2025-02-05 13:25:06 +00:00
2025-02-17 09:53:26 +00:00
2025-02-05 13:25:06 +00:00
2025-04-15 09:23:26 +00:00
2025-03-28 08:46:43 +00:00
2025-02-05 13:25:06 +00:00
2025-02-05 13:25:06 +00:00
2025-04-16 09:36:34 +01:00
2025-02-05 13:25:06 +00:00
2025-02-17 09:53:26 +00:00
2025-04-16 09:36:34 +01:00
2025-02-11 14:16:59 +00:00
2025-02-05 13:25:06 +00:00
2025-03-14 08:52:41 +00:00
2025-01-06 11:18:54 +00:00
2025-02-05 13:25:06 +00:00
2025-01-06 11:18:54 +00:00
2025-01-06 11:18:54 +00:00
2025-04-28 16:05:36 +00:00
2025-03-28 20:34:32 +00:00
2025-01-06 11:18:54 +00:00
2025-02-05 13:25:06 +00:00
2025-01-06 11:18:54 +00:00
2025-01-06 11:18:54 +00:00
2025-02-05 13:25:06 +00:00
2025-02-05 13:25:06 +00:00
2025-02-05 13:25:06 +00:00
2025-02-05 13:25:06 +00:00
2025-04-30 16:56:21 +01:00
2025-04-30 16:56:21 +01:00
2025-04-09 19:03:09 +00:00
2025-04-22 09:37:47 +00:00
2025-02-05 13:25:06 +00:00
2025-02-05 13:25:06 +00:00
2025-01-06 11:18:54 +00:00
2025-03-18 17:54:32 +00:00
2025-01-06 11:18:54 +00:00
2025-04-30 16:56:21 +01:00
2025-02-05 13:25:06 +00:00
2025-04-02 10:05:05 +00:00
2025-04-16 09:36:34 +01:00
2025-01-06 11:18:54 +00:00
2025-02-05 13:25:06 +00:00
2025-01-06 11:18:54 +00:00
2025-02-05 13:25:06 +00:00
2025-02-05 13:25:06 +00:00
2025-02-05 13:25:06 +00:00
2025-02-05 13:25:06 +00:00
2025-02-05 13:25:06 +00:00
2025-04-30 16:56:21 +01:00
2025-02-05 13:25:06 +00:00
2025-01-06 11:18:54 +00:00
2025-01-06 11:18:54 +00:00
2025-02-05 13:25:06 +00:00
2025-03-24 16:00:47 +00:00
2025-04-10 15:54:41 +00:00
2025-02-05 13:25:06 +00:00
2025-02-05 13:25:06 +00:00
2025-03-28 20:34:32 +00:00
2025-04-14 13:36:34 +00:00
2025-02-05 13:25:06 +00:00
2025-02-05 13:25:06 +00:00
2025-02-05 13:25:06 +00:00
2025-02-18 21:11:36 +00:00
2025-02-05 13:25:06 +00:00
2025-04-16 09:36:34 +01:00
2025-03-18 17:54:32 +00:00
2025-01-06 11:18:54 +00:00
2025-02-05 13:25:06 +00:00
2025-02-14 10:58:20 +00:00
2025-04-14 08:31:21 +00:00
2025-01-06 11:18:54 +00:00
2025-01-06 11:18:54 +00:00
2025-03-18 17:54:32 +00:00
2025-01-06 11:18:54 +00:00
2025-01-06 11:18:54 +00:00
2025-02-10 11:22:58 +00:00
2025-01-14 13:35:20 +00:00
2025-02-05 13:25:06 +00:00
2025-02-05 13:25:06 +00:00