d8a939df5d
Use & enforce snake_case naming convention on config.json settings ( #8062 )
...
* Document and support the established naming convention for config opts
This change:
* Rename `ConfigOptions` to `IConfigOptions` to match code convention/style, plus move it to a dedicated file
* Update comments and surrounding documentation
* Define every single documented option (from element-web's config.md)
* Enable a linter to enforce the convention
* Invent a translation layer for a different change to use
* No attempt to fix build errors from doing this (at this stage)
* Add demo of lint rule in action
* Fix all obvious instances of SdkConfig case conflicts
* Fix tests to use SdkConfig directly
* Add docs to make unset() calling safer
* Appease the linter
* Update documentation to match snake_case_config
* Fix more instances of square brackets off SdkConfig
2022-03-18 10:12:36 -06:00
2acc8fd18b
Implement is_falling_back in accordance to MSC3440 ( #8055 )
2022-03-15 13:52:37 +00:00
744eeb53fe
Don't assume that widget IDs are unique ( #8052 )
...
* Don't assume that widget IDs are unique
Signed-off-by: Robin Townsend <robin@robin.town >
* Don't remove live tiles that don't exist
Signed-off-by: Robin Townsend <robin@robin.town >
* Add unit test for AppTile's live tile tracking
Signed-off-by: Robin Townsend <robin@robin.town >
2022-03-15 12:15:26 +00:00
afadea01a0
Reuse a common part of the translation ( #7978 )
2022-03-14 09:12:02 +00:00
3f67a389c1
Fix incorrect usage of unstable variant of is_falling_back ( #8016 )
2022-03-10 15:32:00 +00:00
319ed3a776
Fix missing summary text for pinned message changes ( #7989 )
...
Signed-off-by: Robin Townsend <robin@robin.town >
2022-03-04 18:35:28 -05:00
d98a73b003
Revert "replace all require(.svg) with esm import" ( #7969 )
...
* Revert "replace all require(svgs) with esm import (#7948 )"
This reverts commit 61cd463a3bkerrya@element.io >
* add shameful eslint ignore
Signed-off-by: Kerry Archibald <kerrya@element.io >
* format eslintrc
Signed-off-by: Kerry Archibald <kerrya@element.io >
* add missed MFileBody change
Signed-off-by: Kerry Archibald <kerrya@element.io >
* one more broken svg
Signed-off-by: Kerry Archibald <kerrya@element.io >
* and ignore it
Signed-off-by: Kerry Archibald <kerrya@element.io >
2022-03-03 17:51:38 +00:00
3572b36648
Fix room list being laggy while scrolling 🐌 ( #7939 )
...
Fix https://github.com/vector-im/element-web/issues/21262
Optimizations:
1. Don't update the `style` (positioning) of hidden tooltips
1. Don't add DOM elements to the page for hidden tooltips
> ## Performance problems broken down
>
>
> ### Hidden tooltips rendering on `scroll`
>
> You can see that the Tooltip render is attached to the `scroll` event at [`src/components/views/elements/Tooltip.tsx#L78-L81`](https://github.com/matrix-org/matrix-react-sdk/blob/31f0a37ca2eeba6a6296787f2fcb33c4b26efebc/src/components/views/elements/Tooltip.tsx#L78-L81 )
>
> The rendering calls [`src/components/views/elements/Tooltip.tsx#L101` -> `updatePosition`](https://github.com/matrix-org/matrix-react-sdk/blob/36adba101caf58afd280e6eedad003b38165be4f/src/components/views/elements/Tooltip.tsx#L101 ) which ends up as an expensive "Recalculate Style" because it uses [`Element.getBoundingClientRect()`](https://developer.mozilla.org/en-US/docs/Web/API/Element/getBoundingClientRect ). This happens many many times within a single `scroll` event. Probably once for each tooltip within the room list **even though no tooltips are event visible as I scroll**. I can see that we're just updating the `style` attribute for a bunch of `.mx_Tooltip_invisible` elements at the end of the document.
>
> Each one of the purple spans below the `scroll` span ends up as a call to `updatePosition`. And a `scroll` event takes 35ms to 60ms to complete which is way over the 16.6ms 60 FPS budget (on a powerful desktop PC), granted these times are with the performance profiling running. This is without the Passbolt extension explained below.
>
> And the room list contains about 141 rooms (`document.querySelectorAll('.mx_RoomTile').length`):
>
> 
>
>
>
> ### Passbolt Chrome browser extension exacerbates the problem
>
> In order to login to Passbolt, it requires a browser extension which defaults to mucking up all pages:
>
> <img src="https://user-images.githubusercontent.com/558581/156275644-bc26b1f5-5d99-4eae-b74b-c2028f2f1baf.png " width="300">
>
>
> The extension source seems to be available: https://github.com/passbolt/passbolt_browser_extension
>
> The Passbolt Chrome extension has a `MutationObserver` listening to all attribute and element changes to the whole `<body>` of the `document` so it can `findAndSetAuthenticationFields` (find form elements and autofill).
>
>
> [`passbolt/passbolt_styleguide` -> `src/react-web-integration/lib/InForm/InFormManager.js#L143`](https://github.com/passbolt/passbolt_styleguide/blob/1c5eddc9102c7cd1029d10dc6836af4722cdba61/src/react-web-integration/lib/InForm/InFormManager.js#L143 )
> ```js
> this.mutationObserver.observe(document.body, { attributes: true, childList: true, subtree: true });
> ```
>
> This causes a bunch of `Forced reflow` because the Tooltip `updatePosition` is mutating the element `style` attribute and Passbolt `MutationObserver` callbacks are querying the whole DOM looking for form elements all in the same frame.
>
> Under the `scroll` event, all of the little spans are the `MutationObserver` -> `findAndSetAuthenticationFields`. With the Passbolt extension, scrolling is verrrrry crunchy and bad.
>
> 
>
>
> #### Workaround
>
> Instead of running Passbolt on all sites, we can enable the extension to only run on the domain for Passbolt instance itself. I'm guessing the Passbolt extension also does autofill stuff on sites but I always login manually to the Passbolt instance so this solution works for me �
>
> **Extensions** -> **Passbolt** -> **Details** -> Change **Site access** to `On specific sites` -> Enter in your Passbolt instance `https://passbolt.example.com/ `
>
> 
>
> *-- https://github.com/vector-im/element-web/issues/21262 *
2022-03-02 13:20:01 -06:00
61cd463a3b
replace all require(svgs) with esm import ( #7948 )
...
Signed-off-by: Kerry Archibald <kerrya@element.io >
2022-03-02 17:14:33 +01:00
df591ee835
Make everything use the KeyBindingManager ( #7907 )
2022-02-28 16:05:52 +00:00
c257bc3f7a
Prefer RoomStateEvent.Update where possible as it fires far less ( #7878 )
2022-02-24 14:39:25 +00:00
c638af703e
Fix vanishing recently viewed menu ( #7887 )
...
Signed-off-by: Robin Townsend <robin@robin.town >
2022-02-24 07:55:57 -05:00
d8ac7cf202
Fix thread summary layout for narrow right panel timeline ( #7838 )
2022-02-23 14:03:46 +00:00
7fa01ffb06
Improve typing around event emitter handlers ( #7816 )
2022-02-22 12:18:08 +00:00
8fccef86d8
Wire up drag-drop file uploads for the thread view ( #7860 )
2022-02-22 11:14:56 +00:00
5b8d440406
type Actions ( #7862 )
...
* type ViewHomPage action
Signed-off-by: Kerry Archibald <kerrya@element.io >
* type spacestore actions
Signed-off-by: Kerry Archibald <kerrya@element.io >
* lint
Signed-off-by: Kerry Archibald <kerrya@element.io >
* add action types
Signed-off-by: Kerry Archibald <kerrya@element.io >
* use new action types in stores
Signed-off-by: Kerry Archibald <kerrya@element.io >
* remove debug change
Signed-off-by: Kerry Archibald <kerrya@element.io >
* stricter keyboard shortcut types
Signed-off-by: Kerry Archibald <kerrya@element.io >
* action comments
Signed-off-by: Kerry Archibald <kerrya@element.io >
2022-02-22 10:04:27 +00:00
57595bc593
Fix misalignment with Event List Summaries ( #7865 )
...
* Fix misalignment with Event List Summaries
* simplify styling
2022-02-22 08:35:58 +00:00
f1e1b7be86
Support "closed" polls whose votes are not visible until they are ended ( #7842 )
2022-02-21 10:21:35 +00:00
fc9a221371
Focus trap in poll creation dialog ( #7847 )
...
* add autofocus
Signed-off-by: Kerry Archibald <kerrya@element.io >
* test
Signed-off-by: Kerry Archibald <kerrya@element.io >
* scope ids
Signed-off-by: Kerry Archibald <kerrya@element.io >
* whitespace
Signed-off-by: Kerry Archibald <kerrya@element.io >
2022-02-18 16:35:08 +00:00
38a547b5d0
Remove ResizeObserver Polyfill ( #7844 )
2022-02-18 13:51:27 +00:00
658590e5bc
More posthog tracking around joining rooms and room search ( #7807 )
2022-02-17 18:03:27 +00:00
a939184e10
Tear down AppTile using lifecycle tracking ( #7833 )
2022-02-17 16:30:36 +00:00
2160fd81c2
Fixes React.js console errors ( #7829 )
2022-02-17 11:46:19 +00:00
7387f3c80a
Allow editing polls ( #7806 )
2022-02-17 09:13:05 +00:00
fa9af44523
Fix left panel widgets causing app crashes (again) ( #7814 )
...
* Add type safety around left panel widget handling
* lint
2022-02-16 13:26:18 -07:00
8d4e83084c
Remove Countly analytics integration ( #7808 )
2022-02-15 16:58:30 +00:00
6793ef33ba
Use the resize observer polyfill consistently ( #7796 )
2022-02-14 23:59:03 +00:00
0cf15d27dc
Fix edge cases around event list summaries with hidden events and redactions ( #7797 )
2022-02-14 23:58:29 +00:00
76fb2abae1
Consolidate, simplify and improve copied tooltips ( #7799 )
2022-02-14 23:54:46 +00:00
ac6a356027
End-to-end test alias publishing flow ( #7779 )
2022-02-11 11:37:31 +00:00
73899bb2e3
Switch to IPC channel for getDesktopCapturerSources ( #7782 )
2022-02-11 10:41:15 +00:00
0d6ef76605
Add analytics for the ViewRoom action ( #7666 )
2022-02-10 14:29:55 +00:00
2f7b26214d
Fix sort order for facepiles which was exactly reverse ( #7771 )
2022-02-10 09:06:45 +00:00
e2196a8731
Event List Summary guard against missing event senders ( #7767 )
2022-02-10 09:03:44 +00:00
714136d4f7
Consolidate RedactionGrouper and HiddenEventGrouper into MELS ( #7739 )
2022-02-09 10:51:12 +00:00
59cdd3edc0
Unify widget header actions with those in right panel ( #7734 )
2022-02-09 10:47:41 +00:00
2b72a2cc2f
Fix view source and devtools showing hljs warnings ( #7759 )
2022-02-09 09:09:06 +00:00
760446c087
Null-guard ELS from null summaryMembers ( #7744 )
2022-02-08 14:26:26 +00:00
ec92102fe3
Properly handle persistent widgets when room is left ( #7724 )
2022-02-07 14:40:22 +00:00
78373e86ea
Truncate long server names on login/register screen ( #7702 )
...
Co-authored-by: Aaron Raimist <aaron@raim.ist >
2022-02-04 10:20:20 +00:00
f0446a23d5
Fix poll creation from a thread ( #7706 )
2022-02-02 17:55:41 +00:00
5b999300b2
Fix the sticker picker ( #7692 )
...
* Fix the sticker picker
Don't stop user widgets on room change: they're not room-specific.
Fixes https://github.com/vector-im/element-web/issues/20797
* Use 'userWidget' prop rather than roomId being defined
2022-02-01 15:34:22 +00:00
98c5f50f36
Fix publishing address wrongly demanding the alias be available ( #7690 )
2022-02-01 15:06:26 +00:00
b04d2de313
Fix left panel widgets causing app-wide crash ( #7659 )
2022-01-28 08:52:46 -07:00
7fa27f5834
Add jump to date functionality to date headers in timeline v2 ( #7339 )
...
Fix https://github.com/vector-im/element-web/issues/7677
Utilizes MSC3030: https://github.com/matrix-org/matrix-doc/pull/3030
https://user-images.githubusercontent.com/558581/150060664-79627573-f4fd-497c-b726-dc3485854bd0.png
2022-01-27 16:32:12 -06:00
efa1667d7e
Remove Unpin option from maximised widget context menu ( #7657 )
2022-01-27 17:08:09 +00:00
3eca71bc84
Unit test ExportDialog ( #7619 )
...
* add test ids to dialog buttons
Signed-off-by: Kerry Archibald <kerrya@element.io >
* unit test ExportDialog
Signed-off-by: Kerry Archibald <kerrya@element.io >
* remove extra snapshot
Signed-off-by: Kerry Archibald <kerrya@element.io >
* fix bad snapshots
Signed-off-by: Kerry Archibald <kerrya@element.io >
* remove wrappers from snapshot
Signed-off-by: Kerry Archibald <kerrya@element.io >
2022-01-27 09:55:08 +01:00
1d02e61655
Improve taken username warning in registration for when request fails ( #7621 )
2022-01-25 10:45:41 +00:00
9d9b77d5e1
Make widgets not reload (persistent) between center and top container ( #7575 )
2022-01-24 15:24:30 +00:00
26e1570dd6
a11y - fix iframes without title ( #7614 )
...
* iframe title in AppTile
Signed-off-by: Kerry Archibald <kerrya@element.io >
* iframe title in hostSignupDialog
Signed-off-by: Kerry Archibald <kerrya@element.io >
* iframe title in MFileBody
* iframe titles in modal widget and int man
Signed-off-by: Kerry Archibald <kerrya@element.io >
* enable jsx-a11y/iframe-has-title rule
Signed-off-by: Kerry Archibald <kerrya@element.io >
2022-01-24 14:07:54 +00:00
Travis Ralston
